From: Przemyslaw Marczak <p.marczak@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC] POWER framework v3 - wish list
Date: Tue, 20 May 2014 10:47:23 +0200 [thread overview]
Message-ID: <537B169B.3070703@samsung.com> (raw)
In-Reply-To: <201405152101.46028.marex@denx.de>
Hello Marek,
On 05/15/2014 09:01 PM, Marek Vasut wrote:
> On Friday, May 09, 2014 at 08:58:02 AM, Przemyslaw Marczak wrote:
>> Hello,
>
> [...]
>
>> struct power_ops_key_power {
>> int (*key_state) (int *state);
>> };
>
> This could be a key input device.
>
>> struct power_ops_rtc {
>> int (*sec) (int set_get, int *val);
>> int (*min) (int set_get, int *val);
>> int (*hour) (int set_get, int *val);
>> int (*day) (int set_get, int *val);
>> int (*month) (int set_get, int *val);
>> int (*year) (int set_get, int *val);
>> };
>
> RTC device.
>
>> struct power_ops_motor {
>> int (*configure) (void);
>> int (*enable) (int time, int gain);
>> };
>>
>> struct power_ops_led_flash {
>> int (*configure) (void);
>> int (*enable) (void);
>> int (*disable) (void);
>> };
>
> LED device.
Yes, they are actually a various devices with separated options.
I looked into some Frescale and Maxim PMICs documentation. And those
integrated devices usually provides various ops on one or two
interfaces. So I think it would be nice to have one framework and e.g.
register available devices options for each interface of each device.
>
> It seems like you're trying to assemble a huge framework while avoiding the
> already-present frameworks. No?
>
You're right - we have some frameworks at present and this framework
could be an additional abstraction level between device and uboot commands.
Device could be presented as it was designed - is it bad idea?
> Best regards,
> Marek Vasut
>
Thanks
--
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com
prev parent reply other threads:[~2014-05-20 8:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <536C7C7A.40107@samsung.com>
2014-05-09 10:25 ` [U-Boot] [RFC] POWER framework v3 - wish list Przemyslaw Marczak
2014-05-19 18:37 ` Simon Glass
2014-05-20 9:16 ` Przemyslaw Marczak
2014-05-20 17:25 ` Simon Glass
2014-05-15 19:01 ` Marek Vasut
2014-05-20 8:47 ` Przemyslaw Marczak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537B169B.3070703@samsung.com \
--to=p.marczak@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox