From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Wed, 21 May 2014 10:18:53 -0600 Subject: [U-Boot] [PATCH V2] cmd_mmc.c: check mmc_init() during mmc dev In-Reply-To: <537C3C42.4080801@samsung.com> References: <1400605052-14714-1-git-send-email-swarren@wwwdotorg.org> <537C3C42.4080801@samsung.com> Message-ID: <537CD1ED.6060309@wwwdotorg.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 05/20/2014 11:40 PM, Jaehoon Chung wrote: > Hi, Stephen. > > i didn't apply your patch. Which repository do you use? It's based on u-boot.git master branch. The latest u-boot-mmc.git master branch is already included in that branch, and it looks like some changes have been applied to cmd_mmc.c in u-boot/master that aren't in u-boot-mmc/master. > Well, if you want to check, can be used "if (mmc_init(mmc))". > > And i'm not sure whether this code is really need or not. Why not? This code is required to solve the problem described in the commit description: > On 05/21/2014 01:57 AM, Stephen Warren wrote: >> From: Bryan Wu >> >> mmc dev ${devnum} will return 0 as success even if there is no card >> inserted. Booting script like tegra-common-post.h will call mmc dev >> ${devnum} to check the mmc device status, it always return 0 even if >> mmc_init() fails.