public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2] cmd_mmc.c: check mmc_init() during mmc dev
Date: Fri, 23 May 2014 12:59:53 -0600	[thread overview]
Message-ID: <537F9AA9.1030004@wwwdotorg.org> (raw)
In-Reply-To: <1400605052-14714-1-git-send-email-swarren@wwwdotorg.org>

On 05/20/2014 10:57 AM, Stephen Warren wrote:
> From: Bryan Wu <cooloney@gmail.com>
> 
> mmc dev ${devnum} will return 0 as success even if there is no card
> inserted. Booting script like tegra-common-post.h will call mmc dev
> ${devnum} to check the mmc device status, it always return 0 even if
> mmc_init() fails.
> 
> Check mmc_init() return value let mmc dev command return failure
> when mmc_init() fails.

For the email archive record, it looks like this same logic has already
been implemented as part of:

1fd93c6e7d8a eMMC: cmd_mmc.c adds the 'rpmb' sub-command for the 'mmc'
command

... which was just recently committed into u-boot-mmc/master.

(See the code in init_mmc_device)

  parent reply	other threads:[~2014-05-23 18:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-20 16:57 [U-Boot] [PATCH V2] cmd_mmc.c: check mmc_init() during mmc dev Stephen Warren
2014-05-21  5:40 ` Jaehoon Chung
2014-05-21 16:18   ` Stephen Warren
2014-05-22  1:41     ` Jaehoon Chung
2014-05-22 16:11       ` Stephen Warren
2014-05-23 18:59 ` Stephen Warren [this message]
2014-06-12 11:13   ` Pantelis Antoniou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=537F9AA9.1030004@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox