[U-Boot] [PATCH v3] fat: Define MAX_CLUSTSIZE using CONFIG_FS_FAT_MAX_CLUSTSIZE

[U-Boot] [PATCH v3] fat: Define MAX_CLUSTSIZE using CONFIG_FS_FAT_MAX_CLUSTSIZE

[Siva Durga Prasad Paladugu]

Define the MAX_CLUSTSIZE to default of 65536 only if
CONFIG_FS_FAT_MAX_CLUSTSIZE is not defined.
This option has been provided to save memory in some
memory constrained cases.

Signed-off-by: Siva Durga Prasad Paladugu <sivadur@xilinx.com>
---

Changes in v3:
-Used CONFIG_FS_FAT_MAX_CLUSTSIZE to define MAX_CLUSTSIZE
as per review comment.

Changes in v2:
-Defined CONFIG_FS_FAT_MAX_CLUSTSIZE and documented as
per review comment.

 README        |    6 ++++++
 include/fat.h |    6 +++++-
 2 files changed, 11 insertions(+), 1 deletions(-)

diff --git a/README b/README
index 5f89552..2f2aba3 100644
--- a/README
+++ b/README
@@ -1613,6 +1613,12 @@ CBFS (Coreboot Filesystem) support
 		filesystem. Available commands are cbfsinit, cbfsinfo, cbfsls
 		and cbfsload.
 
+- FAT(File Allocation Table) filesystem cluster size:
+		CONFIG_FS_FAT_MAX_CLUSTSIZE
+
+		Define the max cluster size for fat operations else
+		a default value of 65536 will be defined.
+
 - Keyboard Support:
 		CONFIG_ISA_KEYBOARD
 
diff --git a/include/fat.h b/include/fat.h
index 81d9790..63cf787 100644
--- a/include/fat.h
+++ b/include/fat.h
@@ -18,7 +18,11 @@
 #define VFAT_MAXSEQ		9   /* Up to 9 of 13 2-byte UTF-16 entries */
 #define PREFETCH_BLOCKS		2
 
-#define MAX_CLUSTSIZE	65536
+#ifndef CONFIG_FS_FAT_MAX_CLUSTSIZE
+#define CONFIG_FS_FAT_MAX_CLUSTSIZE 65536
+#endif
+#define MAX_CLUSTSIZE	CONFIG_FS_FAT_MAX_CLUSTSIZE
+
 #define DIRENTSPERBLOCK	(mydata->sect_size / sizeof(dir_entry))
 #define DIRENTSPERCLUST	((mydata->clust_size * mydata->sect_size) / \
 			 sizeof(dir_entry))
-- 
1.7.4

[U-Boot] [PATCH v3] fat: Define MAX_CLUSTSIZE using CONFIG_FS_FAT_MAX_CLUSTSIZE

[Michal Simek]

On 05/26/2014 03:48 PM, Siva Durga Prasad Paladugu wrote:
> Define the MAX_CLUSTSIZE to default of 65536 only if
> CONFIG_FS_FAT_MAX_CLUSTSIZE is not defined.
> This option has been provided to save memory in some
> memory constrained cases.
> 
> Signed-off-by: Siva Durga Prasad Paladugu <sivadur@xilinx.com>
> ---
> 
> Changes in v3:
> -Used CONFIG_FS_FAT_MAX_CLUSTSIZE to define MAX_CLUSTSIZE
> as per review comment.
> 
> Changes in v2:
> -Defined CONFIG_FS_FAT_MAX_CLUSTSIZE and documented as
> per review comment.
> 
>  README        |    6 ++++++
>  include/fat.h |    6 +++++-
>  2 files changed, 11 insertions(+), 1 deletions(-)
> 
> diff --git a/README b/README
> index 5f89552..2f2aba3 100644
> --- a/README
> +++ b/README
> @@ -1613,6 +1613,12 @@ CBFS (Coreboot Filesystem) support
>  		filesystem. Available commands are cbfsinit, cbfsinfo, cbfsls
>  		and cbfsload.
>  
> +- FAT(File Allocation Table) filesystem cluster size:
> +		CONFIG_FS_FAT_MAX_CLUSTSIZE
> +
> +		Define the max cluster size for fat operations else
> +		a default value of 65536 will be defined.
> +
>  - Keyboard Support:
>  		CONFIG_ISA_KEYBOARD
>  
> diff --git a/include/fat.h b/include/fat.h
> index 81d9790..63cf787 100644
> --- a/include/fat.h
> +++ b/include/fat.h
> @@ -18,7 +18,11 @@
>  #define VFAT_MAXSEQ		9   /* Up to 9 of 13 2-byte UTF-16 entries */
>  #define PREFETCH_BLOCKS		2
>  
> -#define MAX_CLUSTSIZE	65536
> +#ifndef CONFIG_FS_FAT_MAX_CLUSTSIZE
> +#define CONFIG_FS_FAT_MAX_CLUSTSIZE 65536
> +#endif
> +#define MAX_CLUSTSIZE	CONFIG_FS_FAT_MAX_CLUSTSIZE
> +
>  #define DIRENTSPERBLOCK	(mydata->sect_size / sizeof(dir_entry))
>  #define DIRENTSPERCLUST	((mydata->clust_size * mydata->sect_size) / \
>  			 sizeof(dir_entry))
> 

Acked-by: Michal Simek <monstr@monstr.eu>

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 263 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140528/39abbcfe/attachment.pgp>

[U-Boot] [U-Boot, v3] fat: Define MAX_CLUSTSIZE using CONFIG_FS_FAT_MAX_CLUSTSIZE

[Tom Rini]

On Mon, May 26, 2014 at 07:18:37PM +0530, Siva Durga Prasad Paladugu wrote:

> Define the MAX_CLUSTSIZE to default of 65536 only if
> CONFIG_FS_FAT_MAX_CLUSTSIZE is not defined.
> This option has been provided to save memory in some
> memory constrained cases.
> 
> Signed-off-by: Siva Durga Prasad Paladugu <sivadur@xilinx.com>
> Acked-by: Michal Simek <monstr@monstr.eu>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140605/68ede2d2/attachment.pgp>