public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Michal Simek <monstr@monstr.eu>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] env_eeprom: Assign default environment during board_init_f
Date: Wed, 28 May 2014 14:10:44 +0200	[thread overview]
Message-ID: <5385D244.60003@monstr.eu> (raw)
In-Reply-To: <a924d893-61af-4d83-834c-8351249ae0de@BL2FFO11FD031.protection.gbl>

On 05/26/2014 04:21 PM, Siva Durga Prasad Paladugu wrote:
> Assign default environment and set env valid during board_init_f
> before relocation as the actual environment will be read from eeprom
> later.
> 
> Signed-off-by: Siva Durga Prasad Paladugu <sivadur@xilinx.com>
> ---
> 
> Changes in v2:
> -Handled the same in redundant env case also
> as per review comment.
> 
>  common/env_eeprom.c |   12 ++++++++++--
>  1 files changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/common/env_eeprom.c b/common/env_eeprom.c
> index 490ac73..905d39a 100644
> --- a/common/env_eeprom.c
> +++ b/common/env_eeprom.c
> @@ -147,6 +147,7 @@ int saveenv(void)
>  #ifdef CONFIG_ENV_OFFSET_REDUND
>  int env_init(void)
>  {
> +#ifdef ENV_IS_EMBEDDED
>  	ulong len, crc[2], crc_tmp;
>  	unsigned int off, off_env[2];
>  	uchar buf[64], flags[2];
> @@ -212,12 +213,16 @@ int env_init(void)
>  		gd->env_addr = off_env[1] + offsetof(env_t, data);
>  	else if (gd->env_valid == 1)
>  		gd->env_addr = off_env[0] + offsetof(env_t, data);
> -
> +#else
> +	gd->env_addr = (ulong)&default_environment[0];
> +	gd->env_valid = 1;
> +#endif
>  	return 0;
>  }
>  #else
>  int env_init(void)
>  {
> +#ifdef ENV_IS_EMBEDDED
>  	ulong crc, len, new;
>  	unsigned off;
>  	uchar buf[64];
> @@ -250,7 +255,10 @@ int env_init(void)
>  		gd->env_addr	= 0;
>  		gd->env_valid	= 0;
>  	}
> -
> +#else
> +	gd->env_addr = (ulong)&default_environment[0];
> +	gd->env_valid = 1;
> +#endif
>  	return 0;
>  }
>  #endif

Acked-by: Michal Simek <monstr@monstr.eu>

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 263 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140528/67f56495/attachment.pgp>

  reply	other threads:[~2014-05-28 12:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-26 14:21 [U-Boot] [PATCH v2] env_eeprom: Assign default environment during board_init_f Siva Durga Prasad Paladugu
2014-05-28 12:10 ` Michal Simek [this message]
2014-06-05 22:47 ` [U-Boot] [U-Boot, " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5385D244.60003@monstr.eu \
    --to=monstr@monstr.eu \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox