From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/3] mx28evk: Remove extra CONFIG_ENV_SIZE
Date: Wed, 28 May 2014 17:34:36 +0200 [thread overview]
Message-ID: <5386020C.1040102@denx.de> (raw)
In-Reply-To: <1399592136-24497-1-git-send-email-festevam@gmail.com>
Hi Fabio,
On 09/05/2014 01:35, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> When building a target with CONFIG_ENV_IS_IN_SPI_FLASH the following build
> warning is seen:
>
> include/configs/mx28evk.h:73:0: warning: "CONFIG_ENV_SIZE" redefined [enabled by default]
>
> Each target has its own CONFIG_ENV_SIZE definition, so remove the one that
> does not belong to any target.
>
> While at it, fix a typo.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
Sorry for the noise. I have not applied it. In fact, this breaks the
other mx28evk setup.
./MAKEALL mx28evk_nand
Configuring for mx28evk_nand - Board: mx28evk, Options: ENV_IS_IN_NAND
include/environment.h:85:4: error: #error "Need to define
CONFIG_ENV_SIZE when using CONFIG_ENV_IS_IN_NAND"
include/environment.h:85:4: error: #error "Need to define
CONFIG_ENV_SIZE when using CONFIG_ENV_IS_IN_NAND"
include/environment.h:85:4: error: #error "Need to define
CONFIG_ENV_SIZE when using CONFIG_ENV_IS_IN_NAND"
The only one without errors is the SPI version.
Can you take a look at it ?
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
prev parent reply other threads:[~2014-05-28 15:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-08 23:35 [U-Boot] [PATCH v2 1/3] mx28evk: Remove extra CONFIG_ENV_SIZE Fabio Estevam
2014-05-08 23:35 ` [U-Boot] [PATCH v2 2/3] mx28evk: Add a target for SPI NOR boot Fabio Estevam
2014-05-08 23:35 ` [U-Boot] [PATCH v2 3/3] mx28evk: Add documentation on how to boot from SPI NOR Fabio Estevam
2014-05-19 13:06 ` Fabio Estevam
2014-05-28 15:30 ` [U-Boot] [PATCH v2 1/3] mx28evk: Remove extra CONFIG_ENV_SIZE Stefano Babic
2014-05-28 15:34 ` Stefano Babic [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5386020C.1040102@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox