From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nikita Kiryanov Date: Wed, 28 May 2014 20:06:23 +0300 Subject: [U-Boot] [PATCH v3 06/11] mx6: add structs for mmdc and ddr iomux registers In-Reply-To: <1399526182-11966-7-git-send-email-tharvey@gateworks.com> References: <1399526182-11966-1-git-send-email-tharvey@gateworks.com> <1399526182-11966-7-git-send-email-tharvey@gateworks.com> Message-ID: <5386178F.3070207@compulab.co.il> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Tim, On 08/05/14 08:16, Tim Harvey wrote: > Add memory-mapped structures for MMDC iomux and configuration. Note that > the MMDC configuration registers are common between the IMX6DQ > (IMX6DUAL/IMX6QUAD) and IMX6SDL (IMX6SOLO/IMX6DUALLITE) the iomux > register addresses differ. This requires two sets of structures. > > Add structures to describe DDR3 device information, system information > (memory layout, etc), and MMDC calibration regitsers that can be used to > configure the MMDC dynamically. s/regitsers/registers > > We define these structures for SPL builds instead of including mx6q-ddr.h an > mx6dl-ddr.h which use the same namespace and are only useful for imximage cf > files. What about the usefulness of the structs for U-Boot code? For example, it might be necessary for U-Boot code to query the MMDC registers to setup memory related variables like gd->ram_size and gd->bd->bi_dram[i].size. Sure this can be done using the #defines in the header files, but we lose nothing by making the structs available to U-Boot as well.