From mboxrd@z Thu Jan 1 00:00:00 1970 From: Minkyu Kang Date: Thu, 29 May 2014 10:06:11 +0900 Subject: [U-Boot] [PATCH v2] Exynos: Make sure ps_hold gets set in the SPL In-Reply-To: <1401112281-9334-1-git-send-email-akshay.s@samsung.com> References: <1401112281-9334-1-git-send-email-akshay.s@samsung.com> Message-ID: <53868803.5020609@samsung.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Akshay Saraswat, On 26/05/14 22:51, Akshay Saraswat wrote: > From: Doug Anderson > > Setting ps_hold ought to be one of the first things we do when we > first boot up. If we wait until the main u-boot runs we won't set it > in time and the PMIC may power us back off. > > Moving ps_hold setup into the generic power_init() which > should contain code that's currently duplicated in the > board_power_init() of several boards. > > Signed-off-by: Doug Anderson > Signed-off-by: Akshay Saraswat > Acked-by: Simon Glass > --- > Changes since v1: > - Added "Acked-by". > > arch/arm/cpu/armv7/exynos/lowlevel_init.c | 6 +++++- > arch/arm/cpu/armv7/exynos/power.c | 14 ++++++++++++++ > arch/arm/include/asm/arch-exynos/power.h | 8 ++++++++ > 3 files changed, 27 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/cpu/armv7/exynos/lowlevel_init.c b/arch/arm/cpu/armv7/exynos/lowlevel_init.c > index 11fe5b8..ed966bc 100644 > --- a/arch/arm/cpu/armv7/exynos/lowlevel_init.c > +++ b/arch/arm/cpu/armv7/exynos/lowlevel_init.c > @@ -39,6 +39,7 @@ enum { > DO_CLOCKS = 1 << 1, > DO_MEM_RESET = 1 << 2, > DO_UART = 1 << 3, > + DO_POWER = 1 << 4, > }; > > int do_lowlevel_init(void) > @@ -60,9 +61,12 @@ int do_lowlevel_init(void) > break; > default: > /* This is a normal boot (not a wake from sleep) */ > - actions = DO_CLOCKS | DO_MEM_RESET; > + actions = DO_CLOCKS | DO_MEM_RESET | DO_POWER; > } > > + if (actions & DO_POWER) > + power_init(); I think we don't have to make new function. Please call set_ps_hold_ctrl directly. Thanks, Minkyu Kang.