public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Michal Simek <monstr@monstr.eu>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] zynq: disable -Wstrict-prototypes option for ps7_init.c
Date: Thu, 29 May 2014 07:07:43 +0200	[thread overview]
Message-ID: <5386C09F.9060605@monstr.eu> (raw)
In-Reply-To: <1401327741-31184-1-git-send-email-yamada.m@jp.panasonic.com>

On 05/29/2014 03:42 AM, Masahiro Yamada wrote:
> The files ps7_init.c and ps7_init.h are supposed to be generated by
> hw projects such as Vivado, PlanAhead and then to be copied into
> board/xilinx/zynq directory.
> 
> But some prototypes in them causes annoying warning messages:
> 
>   CC      spl/board/xilinx/zynq/ps7_init.o
> In file included from board/xilinx/zynq/ps7_init.c:50:0:
> board/xilinx/zynq/ps7_init.h:137:1: warning: function declaration isn't a prototype [-Wstrict-prototypes]
> board/xilinx/zynq/ps7_init.h:138:1: warning: function declaration isn't a prototype [-Wstrict-prototypes]
> board/xilinx/zynq/ps7_init.h:139:1: warning: function declaration isn't a prototype [-Wstrict-prototypes]
> board/xilinx/zynq/ps7_init.h:145:1: warning: function declaration isn't a prototype [-Wstrict-prototypes]
> board/xilinx/zynq/ps7_init.c:12602:1: warning: function declaration isn't a prototype [-Wstrict-prototypes]
> board/xilinx/zynq/ps7_init.c:12723:1: warning: function declaration isn't a prototype [-Wstrict-prototypes]
> board/xilinx/zynq/ps7_init.c:12742:1: warning: function declaration isn't a prototype [-Wstrict-prototypes]
> board/xilinx/zynq/ps7_init.c:12761:1: warning: function declaration isn't a prototype [-Wstrict-prototypes]
> board/xilinx/zynq/ps7_init.c:12854:6: warning: function declaration isn't a prototype [-Wstrict-prototypes]
> 
> The prototypes should be
> 
>   int ps7_init(void);
>   int ps7_post_config(void);
>   int ps7_debug(void);
> 
> rather than
> 
>   int ps7_init();
>   int ps7_post_config();
>   int ps7_debug();
> 
> We do not want to be bothered because of automatically generated files.
> But we cannot touch the external projects for now.
> What we can do is to disable -Wstrict-prototypes for ps7_init.c
> 
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> Cc: Michal Simek <michal.simek@xilinx.com>
> ---
>  board/xilinx/zynq/Makefile | 3 +++
>  1 file changed, 3 insertions(+)

Tested-by: Michal Simek <monstr@monstr.eu>

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 263 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140529/e0017e78/attachment.pgp>

      reply	other threads:[~2014-05-29  5:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-29  1:42 [U-Boot] [PATCH] zynq: disable -Wstrict-prototypes option for ps7_init.c Masahiro Yamada
2014-05-29  5:07 ` Michal Simek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5386C09F.9060605@monstr.eu \
    --to=monstr@monstr.eu \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox