public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-boot] [PATCH] mtd: nand: davinci: add header file for driver definitions
Date: Thu, 29 May 2014 19:40:52 +0300	[thread overview]
Message-ID: <53876314.7080606@ti.com> (raw)
In-Reply-To: <53875CA1.6020006@ti.com>


On 05/29/2014 07:13 PM, Murali Karicheri wrote:
> On 5/29/2014 11:58 AM, Ivan Khoronzhuk wrote:
>> The definitions inside emif_defs.h concern davinci nand driver and
>> should be in it's header. So create header file for davinci nand
>> driver and move definitions from emif_defs.h to it.
> Ivan,
>
> It is difficult to see what is done here. Can you rename the file in a 
> separate patch?
> Do it similar to what is done in kernel where aemif driver concerns 
> with bus configuration
> and nand drivers concerns with NAND part of the EMIF driver.

Yes, you are right.
I think there is no reason to rename it at all, as it'll be deleted in 
the following patch.
I'll hold it as is and remove it in the patch
"[U-boot] [PATCH] ARM: keystone: aemif: move aemif driver to 
drivers/memory/ti-aemif.c"

Thanks.

-- 
Regards,
Ivan Khoronzhuk

      reply	other threads:[~2014-05-29 16:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-29 15:58 [U-Boot] [U-boot] [PATCH] mtd: nand: davinci: add header file for driver definitions Ivan Khoronzhuk
2014-05-29 16:13 ` Murali Karicheri
2014-05-29 16:40   ` Ivan Khoronzhuk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53876314.7080606@ti.com \
    --to=ivan.khoronzhuk@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox