From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ivan Khoronzhuk Date: Thu, 29 May 2014 19:40:52 +0300 Subject: [U-Boot] [U-boot] [PATCH] mtd: nand: davinci: add header file for driver definitions In-Reply-To: <53875CA1.6020006@ti.com> References: <1401379122-11469-1-git-send-email-ivan.khoronzhuk@ti.com> <53875CA1.6020006@ti.com> Message-ID: <53876314.7080606@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 05/29/2014 07:13 PM, Murali Karicheri wrote: > On 5/29/2014 11:58 AM, Ivan Khoronzhuk wrote: >> The definitions inside emif_defs.h concern davinci nand driver and >> should be in it's header. So create header file for davinci nand >> driver and move definitions from emif_defs.h to it. > Ivan, > > It is difficult to see what is done here. Can you rename the file in a > separate patch? > Do it similar to what is done in kernel where aemif driver concerns > with bus configuration > and nand drivers concerns with NAND part of the EMIF driver. Yes, you are right. I think there is no reason to rename it at all, as it'll be deleted in the following patch. I'll hold it as is and remove it in the patch "[U-boot] [PATCH] ARM: keystone: aemif: move aemif driver to drivers/memory/ti-aemif.c" Thanks. -- Regards, Ivan Khoronzhuk