public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] Command unit test failure?
Date: Fri, 30 May 2014 13:18:27 -0600	[thread overview]
Message-ID: <5388D983.5010805@wwwdotorg.org> (raw)
In-Reply-To: <CAPnjgZ0th7ZhSux54tbtddwoL7683iqPve2YJapi+Zu3LwxT3Q@mail.gmail.com>

On 05/30/2014 12:07 PM, Simon Glass wrote:
> Hi Stephen,
> 
> I am seeing the failure below when I run the unit tests. I noticed it
> a while ago but thought I might be doing something wrong. Any ideas?

git bisect says:

> git bisect bad
> 95fac6ab4589ec0767b1eac662577866e2b2f423 is the first bad commit
> commit 95fac6ab4589ec0767b1eac662577866e2b2f423
> Author: Simon Glass <sjg@chromium.org>
> Date:   Thu Feb 27 13:25:58 2014 -0700
> 
>     sandbox: Use os functions to read host device tree
>     
>     At present we use U-Boot's filesystem layer to read the sandbox device tree,
>     but this is problematic since it relies on a temporary feauture added
>     there. Since we plan to implement proper block layer support for sandbox,
>     change this code to use the os layer functions instead. Also use the new
>     fdt_create_empty_tree() instead of our own code.
>     
>     Signed-off-by: Simon Glass <sjg@chromium.org>
> 
> :040000 040000 02b649e6f0c3f84f8aff31938ec869ec6ccd964c 1d48977cfbcbb855b2ee2de2bd20b43a39db7837 M	common
> :040000 040000 7982835c46f491ed54f289b79f2ad1567e8f135b a543335107459fb1a759b262573904fd18b8c683 M	disk

No doubt the change to disk/part.c in that commit broke the syntax "host
- $filename" for the "sb save" and "test -e" commands. Is there some
alternate syntax that sandbox should use to access the filesystem, and
hence the unit test commands should be using?

  reply	other threads:[~2014-05-30 19:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-30 18:07 [U-Boot] Command unit test failure? Simon Glass
2014-05-30 19:18 ` Stephen Warren [this message]
2014-05-30 19:32   ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5388D983.5010805@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox