[U-Boot] [PATCH] tam3517: fix NAND detection

[U-Boot] [PATCH] tam3517: fix NAND detection

[Jeroen Hofstee]

commit a0a37183bd7 "ARM: omap: merge GPMC initialization code for
all platform" needs CONFIG_NOR, CONFIG_NAND or CONFIG_CMD_ONENAND
to be set to access flash. Add CONFIG_NAND for tam3517 derived
boards to prevent the following error: "nand: error: Unable to
find NAND settings in GPMC Configuration - quitting"

cc: Stefano Babic <sbabic@denx.de>
Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>
---
 include/configs/tam3517-common.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/configs/tam3517-common.h b/include/configs/tam3517-common.h
index 3522c1a..bd117d5 100644
--- a/include/configs/tam3517-common.h
+++ b/include/configs/tam3517-common.h
@@ -185,6 +185,7 @@
 /* Configure the PISMO */
 #define PISMO1_NAND_SIZE		GPMC_SIZE_128M
 
+#define CONFIG_NAND
 #define CONFIG_NAND_OMAP_GPMC
 #define CONFIG_ENV_IS_IN_NAND
 #define SMNAND_ENV_OFFSET		0x180000 /* environment starts here */
-- 
1.8.3.2

[U-Boot] [PATCH] tam3517: fix NAND detection

[Gupta, Pekon]

>From: Jeroen Hofstee
>
>commit a0a37183bd7 "ARM: omap: merge GPMC initialization code for
>all platform" needs CONFIG_NOR, CONFIG_NAND or CONFIG_CMD_ONENAND
>to be set to access flash. Add CONFIG_NAND for tam3517 derived
>boards to prevent the following error: "nand: error: Unable to
>find NAND settings in GPMC Configuration - quitting"
>
>cc: Stefano Babic <sbabic@denx.de>
>Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>
>---
> include/configs/tam3517-common.h | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/include/configs/tam3517-common.h b/include/configs/tam3517-common.h
>index 3522c1a..bd117d5 100644
>--- a/include/configs/tam3517-common.h
>+++ b/include/configs/tam3517-common.h
>@@ -185,6 +185,7 @@
> /* Configure the PISMO */
> #define PISMO1_NAND_SIZE		GPMC_SIZE_128M
>
>+#define CONFIG_NAND

You should not add CONFIG_NAND directly to include/configs/...
instead this should come from board profiles defined in boards.cfg
refer am335x_evm or description given in header of boards.cfg


with regards, pekon

[U-Boot] [PATCH] tam3517: fix NAND detection

[Stefano Babic]

Hi Gupta,

On 02/06/2014 08:16, Gupta, Pekon wrote:
>> From: Jeroen Hofstee
>>
>> commit a0a37183bd7 "ARM: omap: merge GPMC initialization code for
>> all platform" needs CONFIG_NOR, CONFIG_NAND or CONFIG_CMD_ONENAND
>> to be set to access flash. Add CONFIG_NAND for tam3517 derived
>> boards to prevent the following error: "nand: error: Unable to
>> find NAND settings in GPMC Configuration - quitting"
>>
>> cc: Stefano Babic <sbabic@denx.de>
>> Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>
>> ---
>> include/configs/tam3517-common.h | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/include/configs/tam3517-common.h b/include/configs/tam3517-common.h
>> index 3522c1a..bd117d5 100644
>> --- a/include/configs/tam3517-common.h
>> +++ b/include/configs/tam3517-common.h
>> @@ -185,6 +185,7 @@
>> /* Configure the PISMO */
>> #define PISMO1_NAND_SIZE		GPMC_SIZE_128M
>>
>> +#define CONFIG_NAND
> 
> You should not add CONFIG_NAND directly to include/configs/...
> instead this should come from board profiles defined in boards.cfg
> refer am335x_evm or description given in header of boards.cfg
> 

But TAM3517 is a SOM and it has always NAND. It is slightly different as
the am335x_evm. All boards using this SOM are then affected by this
problem, and fixing it in the SOM configuration file let us to make a
global fix for all boards, instead of adding CONFIG_NAND for each single
profile in boards.cfg.

Best regards,
Stefano


-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

[U-Boot] [PATCH] tam3517: fix NAND detection

[Gupta, Pekon]

>From: Stefano Babic [mailto:sbabic at denx.de]
[...]

>>> diff --git a/include/configs/tam3517-common.h b/include/configs/tam3517-common.h
>>> index 3522c1a..bd117d5 100644
>>> --- a/include/configs/tam3517-common.h
>>> +++ b/include/configs/tam3517-common.h
>>> @@ -185,6 +185,7 @@
>>> /* Configure the PISMO */
>>> #define PISMO1_NAND_SIZE		GPMC_SIZE_128M
>>>
>>> +#define CONFIG_NAND
>>
>> You should not add CONFIG_NAND directly to include/configs/...
>> instead this should come from board profiles defined in boards.cfg
>> refer am335x_evm or description given in header of boards.cfg
>>
>
>But TAM3517 is a SOM and it has always NAND. It is slightly different as
>the am335x_evm. All boards using this SOM are then affected by this
>problem, and fixing it in the SOM configuration file let us to make a
>global fix for all boards, instead of adding CONFIG_NAND for each single
>profile in boards.cfg.
>
Oh sorry, yes I forgot it?s a OMAP3 variant (same family).
So this can also be added to include/configs/ti_omap3_common.h
But as you are not re-using that config file, please proceed with above change.


with regards, pekon

[U-Boot] tam3517: fix NAND detection

[Tom Rini]

On Sat, May 31, 2014 at 05:08:30PM +0200, Jeroen Hofstee wrote:

> commit a0a37183bd7 "ARM: omap: merge GPMC initialization code for
> all platform" needs CONFIG_NOR, CONFIG_NAND or CONFIG_CMD_ONENAND
> to be set to access flash. Add CONFIG_NAND for tam3517 derived
> boards to prevent the following error: "nand: error: Unable to
> find NAND settings in GPMC Configuration - quitting"
> 
> cc: Stefano Babic <sbabic@denx.de>
> Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>

Applied to u-boot-ti/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140606/08e6fe72/attachment.pgp>