From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Mon, 02 Jun 2014 09:22:16 +0200 Subject: [U-Boot] [PATCH] tam3517: fix NAND detection In-Reply-To: <20980858CB6D3A4BAE95CA194937D5E73EAF215E@DBDE04.ent.ti.com> References: <1401548910-26785-1-git-send-email-jeroen@myspectrum.nl> <20980858CB6D3A4BAE95CA194937D5E73EAF215E@DBDE04.ent.ti.com> Message-ID: <538C2628.4090609@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Gupta, On 02/06/2014 08:16, Gupta, Pekon wrote: >> From: Jeroen Hofstee >> >> commit a0a37183bd7 "ARM: omap: merge GPMC initialization code for >> all platform" needs CONFIG_NOR, CONFIG_NAND or CONFIG_CMD_ONENAND >> to be set to access flash. Add CONFIG_NAND for tam3517 derived >> boards to prevent the following error: "nand: error: Unable to >> find NAND settings in GPMC Configuration - quitting" >> >> cc: Stefano Babic >> Signed-off-by: Jeroen Hofstee >> --- >> include/configs/tam3517-common.h | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/include/configs/tam3517-common.h b/include/configs/tam3517-common.h >> index 3522c1a..bd117d5 100644 >> --- a/include/configs/tam3517-common.h >> +++ b/include/configs/tam3517-common.h >> @@ -185,6 +185,7 @@ >> /* Configure the PISMO */ >> #define PISMO1_NAND_SIZE GPMC_SIZE_128M >> >> +#define CONFIG_NAND > > You should not add CONFIG_NAND directly to include/configs/... > instead this should come from board profiles defined in boards.cfg > refer am335x_evm or description given in header of boards.cfg > But TAM3517 is a SOM and it has always NAND. It is slightly different as the am335x_evm. All boards using this SOM are then affected by this problem, and fixing it in the SOM configuration file let us to make a global fix for all boards, instead of adding CONFIG_NAND for each single profile in boards.cfg. Best regards, Stefano -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================