From mboxrd@z Thu Jan 1 00:00:00 1970 From: Josh Wu Date: Wed, 4 Jun 2014 10:27:21 +0800 Subject: [U-Boot] [PATCH] fs: fatwrite: use map_sysmem before use file_fat_write In-Reply-To: References: <1401789178-15748-1-git-send-email-josh.wu@atmel.com> Message-ID: <538E8409.4000406@atmel.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 6/3/2014 10:35 PM, Simon Glass wrote: > Hi Josh, > > On 3 June 2014 03:52, Josh Wu wrote: >> When the map_sysmem, then the fatwrite command can support sandbox. >> Following command will show how to use it: >> => sb bind 0 sd.img >> => fatls host 0 >> => fatwrite host 0 $memaddr filename $filesize >> >> Signed-off-by: Josh Wu >> --- >> common/cmd_fat.c | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/common/cmd_fat.c b/common/cmd_fat.c >> index a12d8fa..21a2145 100644 >> --- a/common/cmd_fat.c >> +++ b/common/cmd_fat.c >> @@ -13,6 +13,7 @@ >> #include >> #include >> #include >> +#include >> #include >> #include >> #include >> @@ -93,6 +94,7 @@ static int do_fat_fswrite(cmd_tbl_t *cmdtp, int flag, >> disk_partition_t info; >> int dev = 0; >> int part = 1; >> + void *buf; >> >> if (argc < 5) >> return cmd_usage(cmdtp); >> @@ -111,7 +113,9 @@ static int do_fat_fswrite(cmd_tbl_t *cmdtp, int flag, >> addr = simple_strtoul(argv[3], NULL, 16); >> count = simple_strtoul(argv[5], NULL, 16); >> >> - size = file_fat_write(argv[4], (void *)addr, count); >> + buf = map_sysmem((void *)addr, count); > Thanks for the patch. > > You should remove the cast here - map_sysmem()'s first parameter is a > U-Boot address as a ulong. Ah, Right. Thank for pointing that. I'll fixed in v2. Best Regards, Josh Wu > >> + size = file_fat_write(argv[4], buf, count); >> + unmap_sysmem(buf); >> if (size == -1) { >> printf("\n** Unable to write \"%s\" from %s %d:%d **\n", >> argv[4], argv[1], dev, part); >> -- >> 1.7.9.5 >> > Regards, > Simon