public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] imx: sata: return failure if not IMX6Q/IMX6D
Date: Thu, 05 Jun 2014 12:53:22 +0200	[thread overview]
Message-ID: <53904C22.9030403@denx.de> (raw)
In-Reply-To: <CAJ+vNU3dov-K35j9PnY0N2cwd+yF9f_s1snUuwsCEksgB39Bgg@mail.gmail.com>

Hi Tim,

On 05/06/2014 12:44, Tim Harvey wrote:
> On Wed, May 7, 2014 at 10:24 PM, Tim Harvey <tharvey@gateworks.com> wrote:
>> The IMX6QUAD/DUAL have SATA, but the IMX6SOLO/DL do not. Return
>> instead of configuring the SATA clock and GPR13 registers.
>>
>> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
>> ---
>>  arch/arm/imx-common/sata.c | 7 ++++++-
>>  1 file changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/imx-common/sata.c b/arch/arm/imx-common/sata.c
>> index 2e69486..c10dd28 100644
>> --- a/arch/arm/imx-common/sata.c
>> +++ b/arch/arm/imx-common/sata.c
>> @@ -8,13 +8,18 @@
>>  #include <asm/arch/iomux.h>
>>  #include <asm/io.h>
>>  #include <asm/arch/clock.h>
>> +#include <asm/arch/sys_proto.h>
>>
>>  int setup_sata(void)
>>  {
>>         struct iomuxc_base_regs *const iomuxc_regs
>>                 = (struct iomuxc_base_regs *)IOMUXC_BASE_ADDR;
>> +       int ret;
>>
>> -       int ret = enable_sata_clock();
>> +       if (!is_cpu_type(MXC_CPU_MX6Q) && !is_cpu_type(MXC_CPU_MX6D))
>> +               return 1;
>> +
>> +       ret = enable_sata_clock();
>>         if (ret)
>>                 return ret;
>>
>> --
>> 1.8.3.2
>>
> 
> Stefano,
> 
> Any comments?
> 

No comments. In my queue it is ready-to-be-applied. I will do it after
the whole SPL series. My plan is to apply them until the end of the week.

Best regards,
Stefano Babic



-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

  reply	other threads:[~2014-06-05 10:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-06  5:22 [U-Boot] [PATCH] dwc_ahsata: return failure for MX6 if not IMX6Q Tim Harvey
2014-05-06  8:17 ` Stefano Babic
2014-05-06 19:55 ` Troy Kisky
2014-05-07  3:55   ` Tim Harvey
2014-05-08  5:23 ` [U-Boot] [PATCH v2] dwc_ahsata: return failure for MX6 if not IMX6Q/IMX6D Tim Harvey
2014-06-05 10:46   ` Tim Harvey
2014-06-06  8:18   ` Stefano Babic
2014-05-08  5:24 ` [U-Boot] [PATCH] imx: sata: return failure " Tim Harvey
2014-06-05 10:44   ` Tim Harvey
2014-06-05 10:53     ` Stefano Babic [this message]
2014-06-06  8:18     ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53904C22.9030403@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox