From: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-boot] [Patch v2] mtd: nand: davinci: add header file for driver definitions
Date: Sat, 7 Jun 2014 00:12:17 +0300 [thread overview]
Message-ID: <53922EB1.3080801@ti.com> (raw)
In-Reply-To: <20140606203458.GN7841@bill-the-cat>
On 06/06/2014 11:34 PM, Tom Rini wrote:
> On Thu, May 29, 2014 at 08:46:22PM +0300, Ivan Khoronzhuk wrote:
>
>> The definitions inside emif_defs.h concern davinci nand driver and
>> should be in it's header. So create header file for davinci nand
>> driver and move definitions from emif_defs.h to it.
>>
>> Acked-by: Vitaly Andrianov <vitalya@ti.com>
>> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>
>> ---
>> arch/arm/cpu/armv7/keystone/aemif.c | 2 +-
>> arch/arm/include/asm/arch-keystone/emif_defs.h | 73 --------------------------
>> arch/arm/include/asm/arch-keystone/nand_defs.h | 23 --------
>> board/ti/k2hk_evm/board.c | 1 -
>> drivers/mtd/nand/davinci_nand.c | 3 +-
>> drivers/mtd/nand/davinci_nand.h | 66 +++++++++++++++++++++++
>> 6 files changed, 68 insertions(+), 100 deletions(-)
>> delete mode 100644 arch/arm/include/asm/arch-keystone/emif_defs.h
>> delete mode 100644 arch/arm/include/asm/arch-keystone/nand_defs.h
>> create mode 100644 drivers/mtd/nand/davinci_nand.h
> This breaks building a bunch of davinci platforms. Further, we should
> put the new header file under arch/arm/include/asm/ti-common/ not
> drivers/mtd/nand/. Can you please update things and reconcile
> arch/arm/include/asm/arch-davinci/emif_defs.h with these new changes?
> Thanks.
>
Yes..I will repost new patch.
Thanks!
--
Regards,
Ivan Khoronzhuk
prev parent reply other threads:[~2014-06-06 21:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-29 17:46 [U-Boot] [U-boot] [Patch v2] mtd: nand: davinci: add header file for driver definitions Ivan Khoronzhuk
2014-06-06 20:34 ` Tom Rini
2014-06-06 21:12 ` Ivan Khoronzhuk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53922EB1.3080801@ti.com \
--to=ivan.khoronzhuk@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox