public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Herbrechtsmeier <stefan@herbrechtsmeier.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] omap3: overo: Select fdtfile for expansion board
Date: Sun, 08 Jun 2014 09:57:27 +0200	[thread overview]
Message-ID: <53941767.8040803@herbrechtsmeier.net> (raw)
In-Reply-To: <CAK8F28kBNw51fbDOgmpG1YiN6Ji1CLBtpr5VzZi2J2WCdJBDPA@mail.gmail.com>

Am 07.06.2014 22:11, schrieb Ash Charles:
> On Sat, Jun 7, 2014 at 10:48 AM, Tom Rini <trini@ti.com> wrote:
>> In this case it might be harder to do this in a shell cmd.  But we
>> _must_ check for fdtfile being unset and only setenv if not already set.
>> And then drop fdtfile from the config file.
> Thanks both for your comments and suggestions.  I agree that fdtfile
> should only be set if it is currently unset---I'll send an updated
> patch.
It would be nice if you only set an environment variable 'expansionname' 
and setup the fdtfile via a command in the environment. This makes sure, 
that under normal condition the fdtfile is not set and thereby not saved 
in the environment with the command saveenv.

> There is actually already a mechanism for environment variables to be
> set by the board eeprom [1][2] so an expansion board could certainly
> set the desired fdtfile name.
At the moment I use this functionality to set the environment variable 
'fdtfile'.

>    The challenge (and my biggest
> motivation for writing the patch) is making sure we select a dtb for
> either 37xx (Overo Storm) or 35xx (non-storm) as otherwise Linux
> doesn't boot.
Maybe you could set an environment variable 'boardname' to 'overo' or 
'overo-storm' and use something like the following environment command:

if test -n \"${boardname}\" && test -n \"${expansionname}\"; then
     setenv fdtfile omap3-${boardname}-${expansionname}.dtb;
fi;

This allows the expansion board to set the expansionname via eeprom and 
works with both overo boards.

>
> --Ash
> [1] http://elinux.org/BeagleBoardPinMux#Expansion_boards
> [2] https://github.com/gumstix/meta-gumstix-extras/blob/dylan/recipes-core/i2c-tools/omap3-writeprom/writeprom.sh

  reply	other threads:[~2014-06-08  7:57 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-06 18:37 [U-Boot] [PATCH] omap3: overo: Select fdtfile for expansion board Ash Charles
2014-06-07 14:29 ` Stefan Herbrechtsmeier
2014-06-07 17:48   ` Tom Rini
2014-06-07 20:11     ` Ash Charles
2014-06-08  7:57       ` Stefan Herbrechtsmeier [this message]
2014-06-09 20:47         ` Ash Charles
2014-06-09 20:47           ` [U-Boot] [Patch v2] " Ash Charles
2014-06-10  7:30             ` Stefan Herbrechtsmeier
2014-06-10 17:17               ` Ash Charles
2014-06-10 18:06                 ` Stefan Herbrechtsmeier
2014-06-10 19:00                   ` Ash Charles
2014-06-10 19:02                     ` [U-Boot] [Patch v3] " Ash Charles
2014-06-10 19:29                       ` Stefan Herbrechtsmeier
2014-06-10 20:28                         ` Ash Charles
2014-06-19 22:02                       ` [U-Boot] [U-Boot, " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53941767.8040803@herbrechtsmeier.net \
    --to=stefan@herbrechtsmeier.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox