public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Iain Paton <ipaton0@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] embestmx6boards: Fix CONFIG_CONSOLE_DEV
Date: Mon, 09 Jun 2014 18:43:11 +0100	[thread overview]
Message-ID: <5395F22F.3010000@gmail.com> (raw)
In-Reply-To: <1402331735-29293-1-git-send-email-fabio.estevam@freescale.com>

On 09/06/14 17:35, Fabio Estevam wrote:
> mars and riot boards use UART2 as console, so CONFIG_CONSOLE_DEV should point
> to 'ttymxc1' instead.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> Untested as I don't have access to this board.
> 
>  include/configs/embestmx6boards.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/configs/embestmx6boards.h b/include/configs/embestmx6boards.h
> index eb91c44..1d5fde6 100644
> --- a/include/configs/embestmx6boards.h
> +++ b/include/configs/embestmx6boards.h
> @@ -20,7 +20,7 @@
>  #include <linux/sizes.h>
>  
>  #define CONFIG_MXC_UART_BASE		UART2_BASE
> -#define CONFIG_CONSOLE_DEV		"ttymxc0"
> +#define CONFIG_CONSOLE_DEV		"ttymxc1"
>  #define CONFIG_MMCROOT			"/dev/mmcblk1p2"
>  
>  #define PHYS_SDRAM_SIZE		(1u * 1024 * 1024 * 1024)
> 

Tested-by: Iain Paton <ipaton0@gmail.com>

I expect that, like me, most people will never see a problem with this as 
it's not used to define the u-Boot console.
For the kernel console, most people are likely to simply use boot.scr to 
override it or completely replace bootcmd with one that doesn't force 
booting from emmc.

Either way, changing this is the correct thing to do.

  reply	other threads:[~2014-06-09 17:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-09 16:35 [U-Boot] [PATCH] embestmx6boards: Fix CONFIG_CONSOLE_DEV Fabio Estevam
2014-06-09 17:43 ` Iain Paton [this message]
2014-06-17 14:36 ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5395F22F.3010000@gmail.com \
    --to=ipaton0@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox