public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ajay Bhargav <ajay.bhargav@einfochips.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 2/2] gpio: Add GPIO driver for Marvell SoC Armada100
Date: Wed, 10 Aug 2011 13:36:48 +0530 (IST)	[thread overview]
Message-ID: <539775507.72547.1312963608728.JavaMail.root@ahm.einfochips.com> (raw)
In-Reply-To: <F766E4F80769BD478052FB6533FA745D19FE39F3D9@SC-VEXCH4.marvell.com>


----- "Prafulla Wadaskar" <prafulla@marvell.com> wrote:

> 
> I suggest below code for this function.
> { 
>   Const unsigned int offset[4] = {0, 4, 8, 0x100}; /* gpio register
> bank offsets */
>   return (struct gpio_reg *)(ARMD1_GPIO_BASE + offset[bank]);
> }
> 
> Again content in this file are SoC core specific and will duplicate
> for other SoC supports like pantheon.
> 
> Can you please move them to mvgpio.h within #ifdef
> CONFIG_SHEEVA_88SV331xV5?
> I think this should be the final modification for this driver
> support.
> 
> Sorry for the rework.
> 
> Regards..
> Prafulla . .
> 

Hi Prafulla,

Can you please tell me what part of code should be moved to mvgpio.h?
I have no idea about number of banks in other SOCs with same core.

I will do the changes as per suggestion.

Thanks & Regards,
Ajay Bhargav

  reply	other threads:[~2011-08-10  8:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-08  6:09 [U-Boot] [PATCH v3 2/2] gpio: Add GPIO driver for Marvell SoC Armada100 Ajay Bhargav
2011-08-10  8:09 ` Prafulla Wadaskar
2011-08-10  8:06   ` Ajay Bhargav [this message]
2011-08-10  8:22     ` Prafulla Wadaskar
2011-08-10  8:32       ` Ajay Bhargav
2011-08-10  8:54         ` Prafulla Wadaskar
     [not found] <1874942368.72721.1312964851129.JavaMail.root@ahm.einfochips.com>
2011-08-10  8:28 ` Ajay Bhargav

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=539775507.72547.1312963608728.JavaMail.root@ahm.einfochips.com \
    --to=ajay.bhargav@einfochips.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox