public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ubifs: don't self assign values
Date: Wed, 11 Jun 2014 06:28:55 +0200	[thread overview]
Message-ID: <5397DB07.1010506@denx.de> (raw)
In-Reply-To: <1402435643-11294-1-git-send-email-jeroen@myspectrum.nl>

Hello Jeroen,

Am 10.06.2014 23:27, schrieb Jeroen Hofstee:
> It seems the code tries to trick the compiler the argument
> is actually used. However compilers became too smart too
> fool them so easily an now warn. Checking gcc and clang
> does not seem to emit a warning. If so it should be decorated
> with unused / (void).
>
> cc: Stefan Roese<sr@denx.de>
> Signed-off-by: Jeroen Hofstee<jeroen@myspectrum.nl>
> ---
>   fs/ubifs/recovery.c | 1 -
>   fs/ubifs/scan.c     | 1 -
>   2 files changed, 2 deletions(-)

I posted an update for MTD/UBI/UBIFS with Linux 3.14 here:

[U-Boot] [RFC, PATCH v2 0/4] mtd, ubi, ubifs: resync with Linux-3.14
http://lists.denx.de/pipermail/u-boot/2014-May/180001.html

Could you try this series? There only your change in "fs/ubifs/recovery.c"
is needed ... and as this code comes from Linux, maybe it is worth
to post this change also for Linux?

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

  reply	other threads:[~2014-06-11  4:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-10 21:27 [U-Boot] [PATCH] ubifs: don't self assign values Jeroen Hofstee
2014-06-11  4:28 ` Heiko Schocher [this message]
2014-06-11 18:38   ` Jeroen Hofstee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5397DB07.1010506@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox