From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Thu, 12 Jun 2014 10:19:08 -0600 Subject: [U-Boot] [PATCH 3/3] cmd_mmc: make mmc dev always re-probe the HW In-Reply-To: <15F70FA9-6890-4480-9838-9CB9F03B062A@antoniou-consulting.com> References: <1400873087-20921-1-git-send-email-swarren@wwwdotorg.org> <1400873087-20921-3-git-send-email-swarren@wwwdotorg.org> <15F70FA9-6890-4480-9838-9CB9F03B062A@antoniou-consulting.com> Message-ID: <5399D2FC.3080700@wwwdotorg.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 06/12/2014 05:31 AM, Pantelis Antoniou wrote: > On May 23, 2014, at 10:24 PM, Stephen Warren wrote: >> Currently, U-Boot behaves as follows: >> >> - Begin with no SD card inserted in "mmc 1" >> - Execute: mmc dev 1 >> - This fails, since there is no card >> - User plugs in an SD card >> - Execute: mmc dev 1 >> - This still fails, since the HW isn't reprobed. >> >> With this change, U-Boot behaves as follows: >> >> - Begin with no SD card inserted in "mmc 1" >> - Execute: mmc dev 1 >> - This fails, since there is no card >> - User plugs in an SD card >> - Execute: mmc dev 1 >> - The newly present SD card is detected ... > Thanks, applied. > > -- Pantelis > > Acked-by: Pantelis Antoniou Thanks very much for applying these. I'm puzzled why you write Acked-by in the emails, and add it to the commit descriptions when you apply them? FWIW for reference: Acked-by as used by the Linux kernel is usually only used when giving permission to a different maintainer to apply the patches, rather than taking them through the usual tree. Signed-off-by is the tag usually used when applying commits yourself, although there's an unresolved question re: whether adding s-o-b (or presumably anything at all) to commits when applying them is appropriate behaviour for U-Boot.