From mboxrd@z Thu Jan  1 00:00:00 1970
From: Markus Niebel <list-09_u-boot@tqsc.de>
Date: Mon, 16 Jun 2014 17:01:33 +0200
Subject: [U-Boot] [Patch 1/7] Add TQ Systems TQMa6 board support
In-Reply-To: <20140616124148.E21293804AA@gemini.denx.de>
References: <1402915858-1335-1-git-send-email-list-09_u-boot@tqsc.de>
	<1402915858-1335-2-git-send-email-list-09_u-boot@tqsc.de>
	<20140616124148.E21293804AA@gemini.denx.de>
Message-ID: <539F06CD.8020301@tqsc.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Am 16.06.2014 14:41, wrote Wolfgang Denk:
> Dear Markus Niebel,
> 
> In message <1402915858-1335-2-git-send-email-list-09_u-boot@tqsc.de> you wrote:
>>
>> This patch adds the changes to boards.cfg and the board directory
>> under board/tqc.
> 
> ...
>> +#define CONFIG_EXTRA_ENV_SETTINGS                                              \
> ...
>> +	"baudrate="__stringify(CONFIG_BAUDRATE)"\0"                            \
> 
> "baudrate" is already in the standard settings.  You just create a
> duplicated entry here.
> 

Thanks, good to know. Will fix that.

> ...
>> +/* Print Buffer Size */
>> +#define CONFIG_SYS_PBSIZE		(CONFIG_SYS_CBSIZE + sizeof(CONFIG_SYS_PROMPT) + 16)
> 
> WARNING: line over 80 characters
> #1067: FILE: include/configs/tqma6.h:190:
> +#define CONFIG_SYS_PBSIZE              (CONFIG_SYS_CBSIZE + sizeof(CONFIG_SYS_PROMPT) + 16)
> 
> 
> Best regards,
> 
> Wolfgang Denk
>