From mboxrd@z Thu Jan  1 00:00:00 1970
From: Minkyu Kang <mk7.kang@samsung.com>
Date: Tue, 17 Jun 2014 15:28:23 +0900
Subject: [U-Boot] [PATCH v3 5/5] Exynos: Split 5250 and 5420 memory bank
 configuration
In-Reply-To: <1401812251-4846-6-git-send-email-akshay.s@samsung.com>
References: <1401812251-4846-1-git-send-email-akshay.s@samsung.com>
	<1401812251-4846-6-git-send-email-akshay.s@samsung.com>
Message-ID: <539FE007.2040503@samsung.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Akshay Saraswat,

On 04/06/14 01:17, Akshay Saraswat wrote:
> From: Michael Pratt <mpratt@chromium.org>
> 
> Since snow has a different memory configuration than peach, split the
> configuration between the 5250 and 5420. Exynos 5420 supports runtime
> memory configuration detection, and can make the determination between 4
> and 7 banks at runtime.

I think this patch should be included to your peach-pit patchset.
And I think, the number of banks and the size of bank seems to board specific feature.
Can you guarantee if it uses same SoC then have same memory banks?

> 
> Include the bank size with the number of banks for context to make the
> number of banks meaningful.
> 
> Signed-off-by: Michael Pratt <mpratt@chromium.org>
> Signed-off-by: Akshay Saraswat <akshay.s@samsung.com>
> Acked-by: Simon Glass <sjg@chromium.org>
> Tested-by: Simon Glass <sjg@chromium.org>
> ---
> Changes since v2:
> 	- Added "Acked-by" & "Tested-by".
> Changes since v1:
> 	- New patch.
> 
>  include/configs/exynos5-dt.h    | 2 --
>  include/configs/exynos5250-dt.h | 5 +++++
>  include/configs/exynos5420.h    | 4 ++++
>  3 files changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/include/configs/exynos5-dt.h b/include/configs/exynos5-dt.h
> index d3ef44c..fd607ee 100644
> --- a/include/configs/exynos5-dt.h
> +++ b/include/configs/exynos5-dt.h
> @@ -161,8 +161,6 @@
>  
>  #define CONFIG_RD_LVL
>  
> -#define CONFIG_NR_DRAM_BANKS	8
> -#define SDRAM_BANK_SIZE		(256UL << 20UL)	/* 256 MB */
>  #define PHYS_SDRAM_1		CONFIG_SYS_SDRAM_BASE
>  #define PHYS_SDRAM_1_SIZE	SDRAM_BANK_SIZE
>  #define PHYS_SDRAM_2		(CONFIG_SYS_SDRAM_BASE + SDRAM_BANK_SIZE)
> diff --git a/include/configs/exynos5250-dt.h b/include/configs/exynos5250-dt.h
> index 10b8942..27aa455 100644
> --- a/include/configs/exynos5250-dt.h
> +++ b/include/configs/exynos5250-dt.h
> @@ -65,4 +65,9 @@
>  #define LCD_YRES			1600
>  #define LCD_BPP			LCD_COLOR16
>  #endif
> +
> +/* DRAM Memory Banks */
> +#define CONFIG_NR_DRAM_BANKS	8
> +#define SDRAM_BANK_SIZE		(256UL << 20UL)	/* 256 MB */
> +
>  #endif  /* __CONFIG_5250_H */
> diff --git a/include/configs/exynos5420.h b/include/configs/exynos5420.h
> index 2ffe5ee..d2a9556 100644
> --- a/include/configs/exynos5420.h
> +++ b/include/configs/exynos5420.h
> @@ -45,4 +45,8 @@
>   */
>  #define CONFIG_SYS_INIT_SP_ADDR	(CONFIG_IRAM_TOP - 0x800)
>  
> +/* DRAM Memory Banks */
> +#define CONFIG_NR_DRAM_BANKS	7
> +#define SDRAM_BANK_SIZE		(512UL << 20UL)	/* 512 MB */
> +
>  #endif	/* __CONFIG_EXYNOS5420_H */
> 

Thanks,
Minkyu Kang.