public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mx6: Fix definition of IOMUXC_GPR12_DEVICE_TYPE_RC
Date: Tue, 17 Jun 2014 16:29:07 +0200	[thread overview]
Message-ID: <53A050B3.3040205@denx.de> (raw)
In-Reply-To: <1402007490-9397-1-git-send-email-festevam@gmail.com>

Hi Fabio,

On 06/06/2014 00:31, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> mx6 reference manual incorrectly states that the DEVICE_TYPE field of 
> IOMUXC_GPR12 register should be configured as '0010' for setting the PCI 
> controller in RC mode. The correct value should be '0100' instead.
> 
> This also aligns with the same value used in the mx6 pci kernel driver.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  arch/arm/include/asm/arch-mx6/iomux.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/include/asm/arch-mx6/iomux.h b/arch/arm/include/asm/arch-mx6/iomux.h
> index f9ee0d9..6a4a632 100644
> --- a/arch/arm/include/asm/arch-mx6/iomux.h
> +++ b/arch/arm/include/asm/arch-mx6/iomux.h
> @@ -39,7 +39,7 @@
>  #define IOMUXC_GPR12_LOS_LEVEL_MASK		(0x1f << 4)
>  #define IOMUXC_GPR12_APPS_LTSSM_ENABLE		(1 << 10)
>  #define IOMUXC_GPR12_DEVICE_TYPE_EP		(0x0 << 12)
> -#define IOMUXC_GPR12_DEVICE_TYPE_RC		(0x2 << 12)
> +#define IOMUXC_GPR12_DEVICE_TYPE_RC		(0x4 << 12)
>  #define IOMUXC_GPR12_DEVICE_TYPE_MASK		(0xf << 12)
>  

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic


-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

      parent reply	other threads:[~2014-06-17 14:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-05 22:31 [U-Boot] [PATCH] mx6: Fix definition of IOMUXC_GPR12_DEVICE_TYPE_RC Fabio Estevam
2014-06-06  2:19 ` Marek Vasut
2014-06-06  9:45 ` Stefano Babic
2014-06-17 14:29 ` Stefano Babic [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53A050B3.3040205@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox