[U-Boot] [PATCH v3 06/11] arm:reset: call the reset_misc() before the cpu reset

Jeroen Hofstee
2014-06-27T20:20:19Z

Hello Przemyslaw,

On 27-06-14 13:34, Przemyslaw Marczak wrote:
> On 06/27/2014 11:40 AM, Minkyu Kang wrote:
>> Dear Przemyslaw Marczak,
>>
>> On 26/06/14 23:15, Przemyslaw Marczak wrote:
>>> On an Odroid U3 board, the SOC is unable to reset the eMMC card
>>> in the DWMMC mode by the cpu software reset. Manual reset of the card
>>> by switching proper gpio pin - fixes this issue.
>>>
>>> Such solution needs to add a call to pre reset function.
>>> This is done by the reset_misc() function, which is called before
>>> reset_cpu().
>>> The function reset_misc() is a weak function.
>>>
>>> Signed-off-by: Przemyslaw Marczak <p.marczak@samsung.com>
>>> Cc: Minkyu Kang <mk7.kang@samsung.com>
>>> Cc: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
>>> Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
>>> Cc: Tom Rini <trini@ti.com>
>>> ---
>>> arch/arm/lib/reset.c | 7 +++++++
>>> include/common.h | 1 +
>>> 2 files changed, 8 insertions(+)
>>>
>>> diff --git a/arch/arm/lib/reset.c b/arch/arm/lib/reset.c
>>> index 7a03580..3b39466 100644
>>> --- a/arch/arm/lib/reset.c
>>> +++ b/arch/arm/lib/reset.c
>>> @@ -23,6 +23,11 @@
>>>
>>> #include <common.h>
>>>
>>> +void __reset_misc(void) {}
>>> +
>>> +void reset_misc(void)
>>> + __attribute((weak, alias("__reset_misc")));
>>> +
can you please use __weak here and provide a prototype, wherever it
ends up in the end. It prevents 3 warnings and makes it type safe..

Regards,
Jeroen