From mboxrd@z Thu Jan 1 00:00:00 1970 From: Minkyu Kang Date: Wed, 18 Jun 2014 16:16:05 +0900 Subject: [U-Boot] [PATCH v3 5/5] Exynos: Split 5250 and 5420 memory bank configuration In-Reply-To: References: <1401812251-4846-1-git-send-email-akshay.s@samsung.com> <1401812251-4846-6-git-send-email-akshay.s@samsung.com> <539FE007.2040503@samsung.com> <53A131EF.9040602@samsung.com> Message-ID: <53A13CB5.9040509@samsung.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Simon Glass, On 18/06/14 15:47, Simon Glass wrote: > Hi Minkyu, > > On 17 June 2014 23:30, Minkyu Kang wrote: >> On 18/06/14 11:11, Simon Glass wrote: >>> Hi Minkyu, >>> >>> On 16 June 2014 23:28, Minkyu Kang wrote: >>>> Dear Akshay Saraswat, >>>> >>>> On 04/06/14 01:17, Akshay Saraswat wrote: >>>>> From: Michael Pratt >>>>> >>>>> Since snow has a different memory configuration than peach, split the >>>>> configuration between the 5250 and 5420. Exynos 5420 supports runtime >>>>> memory configuration detection, and can make the determination between 4 >>>>> and 7 banks at runtime. >>>> >>>> I think this patch should be included to your peach-pit patchset. >>>> And I think, the number of banks and the size of bank seems to board specific feature. >>>> Can you guarantee if it uses same SoC then have same memory banks? >>> >>> I think this is better than what we have there at present. There is a >>> patch from Chromium that puts this in the device tree, but it is >>> probably best dealt with when more patches have landed. >>> >> >> I didn't deny this patch. >> My comment is about present state. >> If you can not guarantee that have same memory banks >> then please split this configuration to each board's configs. > > For Pit which can support 2GB or 4GB, U-Boot detects the correct size > at run-time. So the setting in the config file is the *maximum* memory > supported by that SOC, which is indeed fixed by the SOC and has > nothing to do with the board. I see. Then looks good to me. Thanks, Minkyu Kang.