public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] thor: defer parsing of device string to IO backend
Date: Fri, 20 Jun 2014 09:56:20 -0600	[thread overview]
Message-ID: <53A459A4.6050901@wwwdotorg.org> (raw)
In-Reply-To: <1403249700-16802-1-git-send-email-l.majewski@samsung.com>

On 06/20/2014 01:35 AM, Lukasz Majewski wrote:
> This commit adjust thor downloading function to work correctly with deferred
> device string parsing.

Oops. I should have grep'd for more users of dfu_init_env_entities() and
fixed them up in my commit.

==========
Since this patch also changes behaviour when that function fails, so the
partially parsed entries are freed too, I'd re-write the whole commit
description as:

Comit XXXXX "dfu: defer parsing of device string to IO backend" changed
the function signature of dfu_init_env_entities(). Adjust cmd_thordown.c
to match that change.

Also, apply the same change as commit XXXXX "dfu: free entities when
parsing fails" to cmd_thordown.c.

Fixes: XXXXX ("dfu: defer parsing of device string to IO backend")
Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
==========

But either way,
Reviewed-by: Stephen Warren <swarren@nvidia.com>

  reply	other threads:[~2014-06-20 15:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-20  7:35 [U-Boot] [PATCH] thor: defer parsing of device string to IO backend Lukasz Majewski
2014-06-20 15:56 ` Stephen Warren [this message]
2014-06-23  7:39 ` [U-Boot] [PATCH v2] " Lukasz Majewski
2014-06-23  7:39   ` Lukasz Majewski
2014-06-23  8:36     ` Marek Vasut
2014-06-23 10:40       ` Lukasz Majewski
2014-06-23 19:02   ` Stephen Warren
2014-06-25  7:07     ` Lukasz Majewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53A459A4.6050901@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox