From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ivan Khoronzhuk Date: Fri, 20 Jun 2014 20:02:48 +0300 Subject: [U-Boot] [U-Boot, U-boot, 1/2] common: cmd_nand: add nand ecclayout command In-Reply-To: <1403281870.12851.194.camel@snotra.buserror.net> References: <1400264797-3593-2-git-send-email-ivan.khoronzhuk@ti.com> <20140620010012.GA5906@home.buserror.net> <53A43752.2080400@ti.com> <1403281870.12851.194.camel@snotra.buserror.net> Message-ID: <53A46938.8020605@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 06/20/2014 07:31 PM, Scott Wood wrote: > On Fri, 2014-06-20 at 16:29 +0300, Ivan Khoronzhuk wrote: >> On 06/20/2014 04:00 AM, Scott Wood wrote: >>> On Fri, May 16, 2014 at 09:26:36PM +0300, Khoronzhuk, Ivan wrote: >>>> + } else { >>>> + printf("Setting current device" >>>> + " to ecc layout %d FAILED!\n", idx); >>> Don't wrap user-visible strings (checkpatch should have warned you about >>> this). >> For user's eyes it's not wrapped. > That's not the point. Wrapping it in the source means the user can't > grep for the string. Checkpatch should have issued a warning about > this. This is an exception to the 80 column rule. > > -Scott > > Ok. -- Regards, Ivan Khoronzhuk