From: Minkyu Kang <mk7.kang@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4] Exynos: SPI: Fix reading data from SPI flash
Date: Mon, 23 Jun 2014 17:43:28 +0900 [thread overview]
Message-ID: <53A7E8B0.3000000@samsung.com> (raw)
In-Reply-To: <1403094161-1061-1-git-send-email-akshay.s@samsung.com>
On 18/06/14 21:22, Akshay Saraswat wrote:
> SPI recieve and transfer code in exynos_spi driver has a logical bug.
> We read data in a variable which can hold an integer. Then we assign
> this integer 32 bit value to another variable which has data type uchar.
> Latter represents a unit of our recieve buffer. Everytime when we write
> a value to our recieve buffer we step ahead by 4 units when actually we
> wrote to one unit. This results in the loss of 3 bytes out of every 4
> bytes recieved. This patch intends to fix this bug.
>
> Signed-off-by: Akshay Saraswat <akshay.s@samsung.com>
> Acked-by: Simon Glass <sjg@chromium.org>
> Tested-by: Simon Glass <sjg@chromium.org>
> ---
> Changes since v3:
> - Rebased to top of Tree.
> Changes since v2:
> - Added "Acked-by" & "Tested-by".
> - Changed assignment for *rxp.
> Changes since v1:
> - Added check for step.
>
> drivers/spi/exynos_spi.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
applied to u-boot-samsung.
Thanks,
Minkyu Kang.
prev parent reply other threads:[~2014-06-23 8:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-18 12:22 [U-Boot] [PATCH v4] Exynos: SPI: Fix reading data from SPI flash Akshay Saraswat
2014-06-23 8:43 ` Minkyu Kang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A7E8B0.3000000@samsung.com \
--to=mk7.kang@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox