From mboxrd@z Thu Jan 1 00:00:00 1970 From: Minkyu Kang Date: Mon, 23 Jun 2014 17:43:28 +0900 Subject: [U-Boot] [PATCH v4] Exynos: SPI: Fix reading data from SPI flash In-Reply-To: <1403094161-1061-1-git-send-email-akshay.s@samsung.com> References: <1403094161-1061-1-git-send-email-akshay.s@samsung.com> Message-ID: <53A7E8B0.3000000@samsung.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 18/06/14 21:22, Akshay Saraswat wrote: > SPI recieve and transfer code in exynos_spi driver has a logical bug. > We read data in a variable which can hold an integer. Then we assign > this integer 32 bit value to another variable which has data type uchar. > Latter represents a unit of our recieve buffer. Everytime when we write > a value to our recieve buffer we step ahead by 4 units when actually we > wrote to one unit. This results in the loss of 3 bytes out of every 4 > bytes recieved. This patch intends to fix this bug. > > Signed-off-by: Akshay Saraswat > Acked-by: Simon Glass > Tested-by: Simon Glass > --- > Changes since v3: > - Rebased to top of Tree. > Changes since v2: > - Added "Acked-by" & "Tested-by". > - Changed assignment for *rxp. > Changes since v1: > - Added check for step. > > drivers/spi/exynos_spi.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > applied to u-boot-samsung. Thanks, Minkyu Kang.