public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] ARM: tegra: Disable VPR
Date: Mon, 23 Jun 2014 12:44:40 -0600	[thread overview]
Message-ID: <53A87598.1070903@wwwdotorg.org> (raw)
In-Reply-To: <1403508048-12123-1-git-send-email-acourbot@nvidia.com>

On 06/23/2014 01:20 AM, Alexandre Courbot wrote:
> From: Bryan Wu <pengw@nvidia.com>
> 
> On Tegra114 and Tegra124 platforms, certain display-related registers cannot
> be accessed unless the VPR registers are programmed.  For bootloader, we
> probably don't care about VPR, so we disable it (which counts as programming
> it, and allows those display-related registers to be accessed.
> 
> This patch is based on the commit 5f499646c83ba08079f3fdff6591f638a0ce4c0c
> in Chromium OS U-Boot project.

> diff --git a/arch/arm/cpu/tegra-common/vpr.c b/arch/arm/cpu/tegra-common/vpr.c

> +void config_vpr(void)
> +{
> +	struct mc_ctlr *mc = (struct mc_ctlr *)NV_PA_MC_BASE;
> +
> +	/* VPR is only in T114 and T124 */
> +	switch (tegra_get_chip()) {
> +	case CHIPID_TEGRA114:
> +	case CHIPID_TEGRA124:

You can drop the switch() and call to tegra_get_chip() since this is all
done at compile-time now.

Other than that,
Reviewed-by: Stephen Warren <swarren@nvidia.com>

  reply	other threads:[~2014-06-23 18:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-19  6:58 [U-Boot] [PATCH] ARM: tegra: Disable VPR Alexandre Courbot
2014-06-19 16:08 ` Stephen Warren
2014-06-23  7:20 ` [U-Boot] [PATCH v2] " Alexandre Courbot
2014-06-23 18:44   ` Stephen Warren [this message]
2014-06-24  2:46     ` Alexandre Courbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53A87598.1070903@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox