From: Dan Murphy <dmurphy@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] usb: host: xhci: make sure to power up PHY
Date: Fri, 27 Jun 2014 10:27:30 -0500 [thread overview]
Message-ID: <53AD8D62.8090002@ti.com> (raw)
In-Reply-To: <1403558739-24461-1-git-send-email-balbi@ti.com>
Hi
On 06/23/2014 04:25 PM, Felipe Balbi wrote:
> some boards won't work if the PHY isn't explicitly
> powered up.
>
> Signed-off-by: Felipe Balbi <balbi@ti.com>
> ---
> drivers/usb/host/xhci-omap.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/host/xhci-omap.c b/drivers/usb/host/xhci-omap.c
> index e667810..912b2bd 100644
> --- a/drivers/usb/host/xhci-omap.c
> +++ b/drivers/usb/host/xhci-omap.c
> @@ -98,6 +98,7 @@ static int omap_xhci_core_init(struct omap_xhci *omap)
> {
> int ret = 0;
>
> + usb_phy_power(1);
Should this not be in the omap_usb_phy.c in the omap_enable_phy call below?
I mean you are enabling the PHY right?
> omap_enable_phy(omap);
>
> ret = dwc3_core_init(omap->dwc3_reg);
--
------------------
Dan Murphy
next prev parent reply other threads:[~2014-06-27 15:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-23 21:25 [U-Boot] [PATCH 1/2] usb: host: xhci: make sure to power up PHY Felipe Balbi
2014-06-23 21:25 ` [U-Boot] [PATCH 2/2] usb: phy: omap_usb_phy: implement usb_phy_power() for AM437x Felipe Balbi
2014-06-23 21:28 ` Michael Trimarchi
2014-06-23 21:58 ` Felipe Balbi
2014-06-23 22:02 ` Michael Trimarchi
2014-06-23 22:18 ` [U-Boot] [PATCH v2 " Felipe Balbi
2014-06-24 14:38 ` Michael Trimarchi
2014-06-25 13:50 ` Marek Vasut
2014-07-07 16:14 ` Felipe Balbi
2014-07-07 18:08 ` Marek Vasut
2014-07-09 12:41 ` Tom Rini
2014-07-09 12:48 ` Michael Trimarchi
2014-07-09 16:02 ` Marek Vasut
2014-07-09 21:03 ` Marek Vasut
2014-06-27 15:27 ` Dan Murphy [this message]
2014-06-27 15:36 ` [U-Boot] [PATCH 1/2] usb: host: xhci: make sure to power up PHY Felipe Balbi
2014-06-27 15:37 ` Dan Murphy
2014-07-07 16:14 ` Felipe Balbi
-- strict thread matches above, loose matches on Subject: below --
2014-07-10 4:02 Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53AD8D62.8090002@ti.com \
--to=dmurphy@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox