From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeroen Hofstee <jeroen@myspectrum.nl>
Date: Mon, 30 Jun 2014 20:30:27 +0200
Subject: [U-Boot] [PATCH v3 06/11] arm:reset: call the reset_misc()
 before the cpu reset
In-Reply-To: <53B122D6.6060802@samsung.com>
References: <1402566394-23342-1-git-send-email-p.marczak@samsung.com>
	<1403792137-3113-1-git-send-email-p.marczak@samsung.com>
	<1403792137-3113-7-git-send-email-p.marczak@samsung.com>
	<53AD3C10.9080604@samsung.com> <53AD56C8.8050007@samsung.com>
	<53ADD203.2060305@myspectrum.nl> <53B122D6.6060802@samsung.com>
Message-ID: <53B1ACC3.7010800@myspectrum.nl>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hello Przemyslaw.

[...]
>>>>>
>>>>>   #include <common.h>
>>>>>
>>>>> +void __reset_misc(void) {}
>>>>> +
>>>>> +void reset_misc(void)
>>>>> +    __attribute((weak, alias("__reset_misc")));
>>>>> +
>> can you please use __weak here and provide a prototype, wherever it
>> ends up in the end. It prevents 3 warnings and makes it type safe..
>>
>
> Thanks, I will add the __weak prefix there.
>
thanks
> The prototype of this new function is in file common.h,
> so this is type safe.
>
yup, I see, don't know how I missed that.
> I checked the compilation with options: -W and -pedantic
> on two configs: trats and odroid, and there was no warnings about the 
> function reset_misc.
>
You won't see the warning with -Wall -Wpendantic, but when running make W=1,
which adds -Wmissing-declarations. The alias version typically warns 
with something
like __reset_misc has no previous declaration. That is useful at times,
since it would e.g. complain about [1].

Regards,
Jeroen

[1] http://lists.denx.de/pipermail/u-boot/2014-June/182781.html