public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Bo Shen <voice.shen@atmel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] ARM: atmel: sama5d3xek: enable NOR flash support
Date: Tue, 1 Jul 2014 11:52:49 +0800	[thread overview]
Message-ID: <53B23091.4090305@atmel.com> (raw)
In-Reply-To: <010c01cf9450$848818c0$8d984a40$@pont@sdcsystems.com>

Hi Andy,

On 06/30/2014 06:46 PM, Andy Pont wrote:
> Hi Bo,
>
>>>> +#ifdef CONFIG_CMD_FLASH
>>>> +#define CONFIG_SYS_FLASH_CFI
>>>> +#define CONFIG_FLASH_CFI_DRIVER
>>>> +#define CONFIG_SYS_FLASH_BASE		0x10000000
>>>> +#define CONFIG_SYS_MAX_FLASH_SECT	0x20000
>
> Is this the correct value for CONFIG_SYS_MAX_FLASH_SECT?  Shouldn't it be
> 127 (if we ignore the top boot block) or 131 if they are included?

oops, I fill this with the sector size.
Thanks point it out. Here, I think we should fill with 131.

> Regards,
>
> Andy.
>

Best Regards,
Bo Shen

      reply	other threads:[~2014-07-01  3:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-20  8:15 [U-Boot] [PATCH 0/2] ARM: atmel: sama5d3xek: enable NOR flash support Bo Shen
2014-06-20  8:16 ` [U-Boot] [PATCH 1/2] ARM: atmel: sama5d3xek: add nor flash init function Bo Shen
2014-06-20  8:16 ` [U-Boot] [PATCH 2/2] ARM: atmel: sama5d3xek: enable NOR flash support Bo Shen
2014-06-30  9:55   ` Andy Pont
2014-06-30 10:01     ` Bo Shen
2014-06-30 10:46       ` Andy Pont
2014-07-01  3:52         ` Bo Shen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53B23091.4090305@atmel.com \
    --to=voice.shen@atmel.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox