public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 0/6] usb: ci_udc: fixes and cleanups
Date: Tue, 01 Jul 2014 16:52:52 -0600	[thread overview]
Message-ID: <53B33BC4.7020209@wwwdotorg.org> (raw)
In-Reply-To: <53B33960.40300@posteo.de>

On 07/01/2014 04:42 PM, J?rg Krause wrote:
> 
> On 07/01/2014 11:36 PM, Stephen Warren wrote:
>> [snip]
>> Can you please try one more thing:
>>
>> Go back to u-boot-usb/master plus just your board support patches. Apply
>> the following and test that:
>>
>>> diff --git a/drivers/usb/gadget/ci_udc.c b/drivers/usb/gadget/ci_udc.c
>>> index a6433e8d2d8d..13be1b73d3d1 100644
>>> --- a/drivers/usb/gadget/ci_udc.c
>>> +++ b/drivers/usb/gadget/ci_udc.c
>>> @@ -209,9 +209,9 @@ ci_ep_alloc_request(struct usb_ep *ep, unsigned int gfp_flags)
>>>         ci_req = memalign(ARCH_DMA_MINALIGN, sizeof(*ci_req));
>>>         if (!ci_req)
>>>                 return NULL;
>>> +       memset(ci_req, 0, sizeof(*ci_req));
>>>  
>>>         INIT_LIST_HEAD(&ci_req->queue);
>>> -       ci_req->b_buf = 0;
>>>  
>>>         if (num == 0)
>>>                 controller.ep0_req = ci_req;
>> Thanks.
> 
> Applied and tested with printf in cache.c enabled. ttp runs more than
> three times in row without a timeout error.

Excellent, I guess that does make sense now.

An equivalent of that change is included in patch 6/6, so that explains
why you saw it fix your problem.

s3c_udc also needs the change above, so I'll go send a patch for that.

Thanks for testing, and it's great that we got to the bottom of this.

  parent reply	other threads:[~2014-07-01 22:52 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-01 17:41 [U-Boot] [PATCH 0/6] usb: ci_udc: fixes and cleanups Stephen Warren
2014-07-01 17:41 ` [U-Boot] [PATCH 1/6] usb: ci_udc: fix ci_flush_{qh, qtd} calls in ci_udc_probe() Stephen Warren
2014-07-01 17:41 ` [U-Boot] [PATCH 2/6] usb: ci_udc: don't assume QTDs are adjacent when transmitting ZLPs Stephen Warren
2014-07-01 17:41 ` [U-Boot] [PATCH 3/6] usb: ci_udc: lift ilist size calculations to global scope Stephen Warren
2014-07-01 17:41 ` [U-Boot] [PATCH 4/6] usb: ci_udc: fix items array size/stride calculation Stephen Warren
2014-07-01 17:41 ` [U-Boot] [PATCH 5/6] usb: ci_udc: remove controller.items array Stephen Warren
2014-07-01 17:41 ` [U-Boot] [PATCH 6/6] usb: ci_udc: don't memalign() struct ci_req allocations Stephen Warren
2014-07-01 21:25 ` [U-Boot] [PATCH 0/6] usb: ci_udc: fixes and cleanups Jörg Krause
2014-07-01 21:31   ` Stephen Warren
2014-07-01 21:36     ` Stephen Warren
2014-07-01 22:42       ` Jörg Krause
2014-07-01 22:51         ` Marek Vasut
2014-07-01 22:52         ` Stephen Warren [this message]
2014-07-01 21:57     ` Jörg Krause

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53B33BC4.7020209@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox