From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Warren <swarren@wwwdotorg.org>
Date: Tue, 01 Jul 2014 16:52:52 -0600
Subject: [U-Boot] [PATCH 0/6] usb: ci_udc: fixes and cleanups
In-Reply-To: <53B33960.40300@posteo.de>
References: <1404236478-22666-1-git-send-email-swarren@wwwdotorg.org>
	<53B32756.6020407@posteo.de> <53B328C4.60300@wwwdotorg.org>
	<53B329C9.8030708@wwwdotorg.org> <53B33960.40300@posteo.de>
Message-ID: <53B33BC4.7020209@wwwdotorg.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 07/01/2014 04:42 PM, J?rg Krause wrote:
> 
> On 07/01/2014 11:36 PM, Stephen Warren wrote:
>> [snip]
>> Can you please try one more thing:
>>
>> Go back to u-boot-usb/master plus just your board support patches. Apply
>> the following and test that:
>>
>>> diff --git a/drivers/usb/gadget/ci_udc.c b/drivers/usb/gadget/ci_udc.c
>>> index a6433e8d2d8d..13be1b73d3d1 100644
>>> --- a/drivers/usb/gadget/ci_udc.c
>>> +++ b/drivers/usb/gadget/ci_udc.c
>>> @@ -209,9 +209,9 @@ ci_ep_alloc_request(struct usb_ep *ep, unsigned int gfp_flags)
>>>         ci_req = memalign(ARCH_DMA_MINALIGN, sizeof(*ci_req));
>>>         if (!ci_req)
>>>                 return NULL;
>>> +       memset(ci_req, 0, sizeof(*ci_req));
>>>  
>>>         INIT_LIST_HEAD(&ci_req->queue);
>>> -       ci_req->b_buf = 0;
>>>  
>>>         if (num == 0)
>>>                 controller.ep0_req = ci_req;
>> Thanks.
> 
> Applied and tested with printf in cache.c enabled. ttp runs more than
> three times in row without a timeout error.

Excellent, I guess that does make sense now.

An equivalent of that change is included in patch 6/6, so that explains
why you saw it fix your problem.

s3c_udc also needs the change above, so I'll go send a patch for that.

Thanks for testing, and it's great that we got to the bottom of this.