public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] powerpc/t1040: fix i2c2 address on t1040qds and t104xrdb
Date: Tue, 1 Jul 2014 16:46:15 -0700	[thread overview]
Message-ID: <53B34847.3030300@freescale.com> (raw)
In-Reply-To: <de21c44c007e4ac0b3810d374840e2c5@BLUPR03MB135.namprd03.prod.outlook.com>

Shengzhou,

If u-boot uses 2nd I2C controller, it is good to have some comments. Please
complete with four I2C controllers' offset.

York


On 07/01/2014 12:37 AM, Jain Priyanka-B32167 wrote:
> Hello Shengzhou,
> 
> T1040 has two dual I2C controller.
> First Dual I2C Controller : 0x1180000 (first i2c bus), 0x1181000(second I2C bus)
> Second Dual I2C Controller : 0x1190000 (third i2c bus), 0x1191000(fourth I2C bus)
> 
> 
> My understanding is CONFIG_SYS_FSL_I2C_OFFSET is offset for first I2C controller and  CONFIG_SYS_FSL_I2C2_OFFSET is offset for second I2C controller.
> Have you checked for dual I2C controller, CONFIG_SYS_FSL_I2C2_OFFSET implies offset for second I2C bus, not the controller?
> 
> 
> Regards
> Priyanka
>> -----Original Message-----
>> From: u-boot-bounces at lists.denx.de [mailto:u-boot-bounces at lists.denx.de]
>> On Behalf Of Shengzhou Liu
>> Sent: Tuesday, July 01, 2014 11:32 AM
>> To: u-boot at lists.denx.de; Sun York-R58495
>> Subject: [U-Boot] [PATCH] powerpc/t1040: fix i2c2 address on t1040qds and
>> t104xrdb
>>
>> The base address of I2C2 is 0x118100 instead of 0x119000.
>>
>> Signed-off-by: Shengzhou Liu <Shengzhou.Liu@freescale.com>
>> ---
>>  include/configs/T1040QDS.h | 2 +-
>>  include/configs/T104xRDB.h | 2 +-
>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/include/configs/T1040QDS.h b/include/configs/T1040QDS.h
>> index 2215ac8..5b75562 100644
>> --- a/include/configs/T1040QDS.h
>> +++ b/include/configs/T1040QDS.h
>> @@ -443,7 +443,7 @@ unsigned long get_board_ddr_clk(void);
>>  #define CONFIG_SYS_FSL_I2C2_SPEED	50000	/* I2C speed in Hz */
>>  #define CONFIG_SYS_FSL_I2C2_SLAVE	0x7F
>>  #define CONFIG_SYS_FSL_I2C_OFFSET	0x118000
>> -#define CONFIG_SYS_FSL_I2C2_OFFSET	0x119000
>> +#define CONFIG_SYS_FSL_I2C2_OFFSET	0x118100
>>
>>  #define I2C_MUX_PCA_ADDR		0x77
>>  #define I2C_MUX_PCA_ADDR_PRI		0x77 /* Primary Mux*/
>> diff --git a/include/configs/T104xRDB.h b/include/configs/T104xRDB.h
>> index e564cb7..e265786 100644
>> --- a/include/configs/T104xRDB.h
>> +++ b/include/configs/T104xRDB.h
>> @@ -441,7 +441,7 @@
>>  #define CONFIG_SYS_FSL_I2C2_SPEED	400000	/* I2C speed in Hz */
>>  #define CONFIG_SYS_FSL_I2C2_SLAVE	0x7F
>>  #define CONFIG_SYS_FSL_I2C_OFFSET	0x118000
>> -#define CONFIG_SYS_FSL_I2C2_OFFSET	0x119000
>> +#define CONFIG_SYS_FSL_I2C2_OFFSET	0x118100
>>
>>  /* I2C bus multiplexer */
>>  #define I2C_MUX_PCA_ADDR                0x70
>> --
>> 1.8.0
>>
>> _______________________________________________
>> U-Boot mailing list
>> U-Boot at lists.denx.de
>> http://lists.denx.de/mailman/listinfo/u-boot

  reply	other threads:[~2014-07-01 23:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-01  6:02 [U-Boot] [PATCH] powerpc/t1040: fix i2c2 address on t1040qds and t104xrdb Shengzhou Liu
2014-07-01  7:37 ` Priyanka Jain
2014-07-01 23:46   ` York Sun [this message]
2014-07-07  3:02     ` Shengzhou.Liu at freescale.com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53B34847.3030300@freescale.com \
    --to=yorksun@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox