public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jaehoon Chung <jh80.chung@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 08/12] samsung: board: enable support of multiple board types
Date: Fri, 04 Jul 2014 14:49:36 +0900	[thread overview]
Message-ID: <53B64070.4060309@samsung.com> (raw)
In-Reply-To: <1404301814-3657-9-git-send-email-p.marczak@samsung.com>

On 07/02/2014 08:50 PM, Przemyslaw Marczak wrote:
> This change adds declaration of functions:
> - set_board_type() - called at checkboard()
> - get_board_type() - called at checkboard()
> - get_board_name()
> 
> For supporting multiple board types in a one config - it is welcome
> to display the current board model. This is what get_board_type()
> should return.
> 
> Signed-off-by: Przemyslaw Marczak <p.marczak@samsung.com>
> Cc: Piotr Wilczek <p.wilczek@samsung.com>
> Cc: Minkyu Kang <mk7.kang@samsung.com>
> 
> ---
> Changes v3:
> - change the commit order
> - include/samsung/misc.h: add new functions declaration
> - update a commit message
> 
> Changes v4:
> - checkboard(): remove redundant variable
> ---
>  board/samsung/common/board.c | 12 +++++++++---
>  include/samsung/misc.h       |  5 +++++
>  2 files changed, 14 insertions(+), 3 deletions(-)
> 
> diff --git a/board/samsung/common/board.c b/board/samsung/common/board.c
> index a46e87b..3e27130 100644
> --- a/board/samsung/common/board.c
> +++ b/board/samsung/common/board.c
> @@ -280,11 +280,17 @@ int board_mmc_init(bd_t *bis)
>  #ifdef CONFIG_DISPLAY_BOARDINFO
>  int checkboard(void)
>  {
> -	const char *board_name;
> +	const char *board_info;
Is there a reason that it's renaming?

Best Regards,
Jaehoon Chung
>  
> -	board_name = fdt_getprop(gd->fdt_blob, 0, "model", NULL);
> -	printf("Board: %s\n", board_name ? board_name : "unknown");
> +	board_info = fdt_getprop(gd->fdt_blob, 0, "model", NULL);
> +	printf("Board: %s\n", board_info ? board_info : "unknown");
> +#ifdef CONFIG_BOARD_TYPES
> +	set_board_type();
>  
> +	board_info = get_board_type();
> +
> +	printf("Model: %s\n", board_info ? board_info : "unknown");
> +#endif
>  	return 0;
>  }
>  #endif
> diff --git a/include/samsung/misc.h b/include/samsung/misc.h
> index e82bf32..cc41997 100644
> --- a/include/samsung/misc.h
> +++ b/include/samsung/misc.h
> @@ -33,5 +33,10 @@ char *get_dfu_alt_system(void);
>  char *get_dfu_alt_boot(void);
>  void set_dfu_alt_info(void);
>  #endif
> +#ifdef CONFIG_BOARD_TYPES
> +void set_board_type(void);
> +const char *get_board_type(void);
> +const char *get_board_name(void);
> +#endif
>  
>  #endif /* __SAMSUNG_MISC_COMMON_H__ */
> 

  reply	other threads:[~2014-07-04  5:49 UTC|newest]

Thread overview: 86+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-10 11:25 [U-Boot] [PATCH 01/10] samsung: misc: fix soc revision setting in the set_board_info() Przemyslaw Marczak
2014-06-10 11:25 ` [U-Boot] [PATCH 02/10] exynos: pinmux: fix the gpio names for exynos4x12 mmc Przemyslaw Marczak
2014-06-11 10:03   ` Jaehoon Chung
2014-06-10 11:32 ` [U-Boot] [PATCH 03/10] board:samsung: check the mmc boot device and init the right mmc driver Przemyslaw Marczak
2014-06-10 11:32 ` [U-Boot] [PATCH 04/10] samsung: misc: set the dfu bootloader setting at boot time Przemyslaw Marczak
2014-06-11  2:03   ` Inha Song
2014-06-11 13:07     ` Przemyslaw Marczak
2014-06-10 11:32 ` [U-Boot] [PATCH 05/10] arm:reset: call the reset_misc() before the cpu reset Przemyslaw Marczak
2014-06-10 11:33 ` [U-Boot] [PATCH 06/10] samsung: misc: set_board_info: check the board type to set fdt file name Przemyslaw Marczak
2014-06-10 11:33 ` [U-Boot] [PATCH 07/10] samsung: board: checkboard: call get_board_type() for CONFIG_BOARD_TYPES Przemyslaw Marczak
2014-06-10 11:33 ` [U-Boot] [PATCH 08/10] odroid: add board file for Odroid X2/U3 based on Samsung Exynos4412 Przemyslaw Marczak
2014-06-11  1:33   ` Inha Song
2014-06-11 12:48     ` Przemyslaw Marczak
2014-06-10 11:33 ` [U-Boot] [PATCH 09/10] odroid: add odroid U3/X2 device tree description Przemyslaw Marczak
2014-06-10 11:33 ` [U-Boot] [PATCH 10/10] odroid: add odroid_config Przemyslaw Marczak
2014-06-12  9:46 ` [U-Boot] [PATCH v2 01/11] samsung: misc: fix soc revision setting in the set_board_info() Przemyslaw Marczak
2014-06-12  9:46   ` [U-Boot] [PATCH v2 02/11] exynos: pinmux: fix the gpio names for exynos4x12 mmc Przemyslaw Marczak
2014-06-12  9:46   ` [U-Boot] [PATCH v2 03/11] board:samsung: check the mmc boot device and init the right mmc driver Przemyslaw Marczak
2014-06-18  6:30     ` Minkyu Kang
2014-06-18 10:47       ` Przemyslaw Marczak
2014-06-19  1:10         ` Minkyu Kang
2014-06-12  9:46   ` [U-Boot] [PATCH v2 04/11] drivers:dfu: new feature: separated bootloader alt setting Przemyslaw Marczak
2014-06-16 19:52     ` Stephen Warren
2014-06-17 10:20       ` Przemyslaw Marczak
2014-06-17 16:36         ` Stephen Warren
2014-06-18 10:56           ` Przemyslaw Marczak
2014-06-18 15:46             ` Stephen Warren
2014-06-23 10:09               ` Przemyslaw Marczak
2014-06-12  9:46   ` [U-Boot] [PATCH v2 05/11] samsung: misc: set the dfu bootloader setting at boot time Przemyslaw Marczak
2014-06-12  9:46   ` [U-Boot] [PATCH v2 06/11] arm:reset: call the reset_misc() before the cpu reset Przemyslaw Marczak
2014-06-12  9:46   ` [U-Boot] [PATCH v2 07/11] samsung: misc: set_board_info: check the board type to set fdt file name Przemyslaw Marczak
2014-06-12  9:46   ` [U-Boot] [PATCH v2 08/11] samsung: board: checkboard: call get_board_type() for CONFIG_BOARD_TYPES Przemyslaw Marczak
2014-06-12  9:46   ` [U-Boot] [PATCH v2 09/11] odroid: add board file for Odroid X2/U3 based on Samsung Exynos4412 Przemyslaw Marczak
2014-06-12  9:46   ` [U-Boot] [PATCH v2 10/11] odroid: add odroid U3/X2 device tree description Przemyslaw Marczak
2014-06-12  9:46   ` [U-Boot] [PATCH v2 11/11] odroid: add odroid_config Przemyslaw Marczak
2014-06-26 14:15   ` [U-Boot] [PATCH v3 00/11] Add support to Odroid U3/X2 Przemyslaw Marczak
2014-06-26 14:15     ` [U-Boot] [PATCH v3 01/11] exynos: pinmux: fix the gpio names for exynos4x12 mmc Przemyslaw Marczak
2014-06-26 14:15     ` [U-Boot] [PATCH v3 02/11] board:samsung: add function boot_device() for checking boot medium Przemyslaw Marczak
2014-06-27  9:40       ` Minkyu Kang
2014-06-27 11:33         ` Przemyslaw Marczak
2014-06-26 14:15     ` [U-Boot] [PATCH v3 03/11] board:samsung: check the boot device and init the right mmc driver Przemyslaw Marczak
2014-06-27  9:40       ` Minkyu Kang
2014-06-27  9:45         ` Jaehoon Chung
2014-06-27 11:38           ` Przemyslaw Marczak
2014-06-27 11:34         ` Przemyslaw Marczak
2014-06-26 14:15     ` [U-Boot] [PATCH v3 04/11] samsung: misc: add function for setting $dfu_alt_info Przemyslaw Marczak
2014-06-26 14:15     ` [U-Boot] [PATCH v3 05/11] samsung:board: misc_init_r: call set_dfu_alt_info() Przemyslaw Marczak
2014-06-26 14:15     ` [U-Boot] [PATCH v3 06/11] arm:reset: call the reset_misc() before the cpu reset Przemyslaw Marczak
2014-06-27  9:40       ` Minkyu Kang
2014-06-27 11:34         ` Przemyslaw Marczak
2014-06-27 20:20           ` Jeroen Hofstee
2014-06-30  8:41             ` Przemyslaw Marczak
2014-06-30 18:30               ` Jeroen Hofstee
2014-07-01 14:16                 ` Przemyslaw Marczak
2014-07-01 14:36           ` Przemyslaw Marczak
2014-07-02  7:03             ` Minkyu Kang
2014-07-02 10:27               ` Przemyslaw Marczak
2014-06-26 14:15     ` [U-Boot] [PATCH v3 07/11] samsung: board: enable support of multiple board types Przemyslaw Marczak
2014-06-27  9:40       ` Minkyu Kang
2014-06-27 11:34         ` Przemyslaw Marczak
2014-06-26 14:15     ` [U-Boot] [PATCH v3 08/11] samsung: misc: use board specific functions to set env board info Przemyslaw Marczak
2014-06-26 14:15     ` [U-Boot] [PATCH v3 09/11] odroid: add board file for Odroid X2/U3 based on Samsung Exynos4412 Przemyslaw Marczak
2014-06-26 14:15     ` [U-Boot] [PATCH v3 10/11] odroid: add odroid U3/X2 device tree description Przemyslaw Marczak
2014-06-26 14:15     ` [U-Boot] [PATCH v3 11/11] odroid: add odroid_config Przemyslaw Marczak
2014-07-02 11:50     ` [U-Boot] [PATCH v4 00/12] Add support to Odroid U3/X2 Przemyslaw Marczak
2014-07-02 11:50       ` [U-Boot] [PATCH v4 01/12] samsung: misc: fix soc revision setting in the set_board_info() Przemyslaw Marczak
2014-07-02 11:50       ` [U-Boot] [PATCH v4 02/12] exynos: pinmux: fix the gpio names for exynos4x12 mmc Przemyslaw Marczak
2014-07-04  5:37         ` Jaehoon Chung
2014-07-02 11:50       ` [U-Boot] [PATCH v4 03/12] arch:exynos: boot mode: add get_boot_mode(), code cleanup Przemyslaw Marczak
2014-07-02 11:50       ` [U-Boot] [PATCH v4 04/12] board:samsung: check the boot device and init the right mmc driver Przemyslaw Marczak
2014-07-04  5:45         ` Jaehoon Chung
2014-07-04  8:07           ` Przemyslaw Marczak
2014-07-04 11:08             ` Jaehoon Chung
2014-07-02 11:50       ` [U-Boot] [PATCH v4 05/12] samsung: misc: add function for setting $dfu_alt_info Przemyslaw Marczak
2014-07-02 11:50       ` [U-Boot] [PATCH v4 06/12] samsung:board: misc_init_r: call set_dfu_alt_info() Przemyslaw Marczak
2014-07-02 11:50       ` [U-Boot] [PATCH v4 07/12] arm:reset: call the reset_misc() before the cpu reset Przemyslaw Marczak
2014-07-02 11:50       ` [U-Boot] [PATCH v4 08/12] samsung: board: enable support of multiple board types Przemyslaw Marczak
2014-07-04  5:49         ` Jaehoon Chung [this message]
2014-07-04  8:08           ` Przemyslaw Marczak
2014-07-02 11:50       ` [U-Boot] [PATCH v4 09/12] samsung: misc: use board specific functions to set env board info Przemyslaw Marczak
2014-07-02 11:50       ` [U-Boot] [PATCH v4 10/12] odroid: add board file for Odroid X2/U3 based on Samsung Exynos4412 Przemyslaw Marczak
2014-07-04  6:07         ` Jaehoon Chung
2014-07-04  8:08           ` Przemyslaw Marczak
2014-07-04 11:12             ` Jaehoon Chung
2014-07-02 11:50       ` [U-Boot] [PATCH v4 11/12] odroid: add odroid U3/X2 device tree description Przemyslaw Marczak
2014-07-02 11:50       ` [U-Boot] [PATCH v4 12/12] odroid: add odroid_config Przemyslaw Marczak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53B64070.4060309@samsung.com \
    --to=jh80.chung@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox