From mboxrd@z Thu Jan 1 00:00:00 1970 From: Diana Craciun Date: Fri, 4 Jul 2014 12:45:29 +0300 Subject: [U-Boot] [PATCH 1/4] ARM: fix the ARCH Timer frequency setting. In-Reply-To: <6f67ea417791403cbb228f665813b3f1@BY2PR03MB505.namprd03.prod.outlook.com> References: <1404381072-42875-1-git-send-email-Li.Xiubo@freescale.com> <1404381072-42875-2-git-send-email-Li.Xiubo@freescale.com> <53B53D41.8050304@freescale.com> <6f67ea417791403cbb228f665813b3f1@BY2PR03MB505.namprd03.prod.outlook.com> Message-ID: <53B677B9.6080502@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 07/04/2014 04:43 AM, Xiubo Li-B47053 wrote: >> Subject: Re: [PATCH 1/4] ARM: fix the ARCH Timer frequency setting. >> >> On 07/03/2014 12:51 PM, Xiubo Li wrote: >>> For some SoCs, the CONFIG_SYS_CLK_FREQ maybe won't equal the ARCH >>> Timer's frequency. >> Can you give an example? >> > In LS1021A-QDS/TWR, the CONFIG_SYS_CLK_FREQ is 100Mhz and the ARCH timer's > Frequency will be 12.5Mhz... > > >>> Here using the CONFIG_TIMER_CLK_FREQ instead if the ARCH Timer's >>> frequency need to config here. >>> >>> Signed-off-by: Xiubo Li >>> --- >>> arch/arm/cpu/armv7/nonsec_virt.S | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/arch/arm/cpu/armv7/nonsec_virt.S >> b/arch/arm/cpu/armv7/nonsec_virt.S >>> index 6f90988..e9766c0 100644 >>> --- a/arch/arm/cpu/armv7/nonsec_virt.S >>> +++ b/arch/arm/cpu/armv7/nonsec_virt.S >>> @@ -147,11 +147,11 @@ ENTRY(_nonsec_init) >>> * we do this here instead. >>> * But first check if we have the generic timer. >>> */ >>> -#ifdef CONFIG_SYS_CLK_FREQ >>> +#ifdef CONFIG_TIMER_CLK_FREQ >> Aren't you breaking the boards which rely on CONFIG_SYS_CLK_FREQ ? > I hadn't found any board is using this in the upstreamed tree, or may > I miss something ? > > If there exist some, and I will redefined it for them here. > > In ARMv7, what could I find is that only vexpress_ca15_tc2 board has enabled > the CONFIG_ARMV7_VIRT without defining it. Yes, this board defines CONFIG_ARMV7_VIRT. In order for this board to work after your changes you need to define CONFIG_TIMER_CLK_FREQ. Diana