* [U-Boot] [PATCH] arm: Fix armv8 compilation error
@ 2014-06-09 20:25 Darwin Rambo
2014-07-04 21:41 ` Albert ARIBAUD
2014-07-05 9:03 ` Albert ARIBAUD
0 siblings, 2 replies; 4+ messages in thread
From: Darwin Rambo @ 2014-06-09 20:25 UTC (permalink / raw)
To: u-boot
From: "Shaibal.Dutta" <shaibal.dutta@broadcom.com>
Fix following compilation error when CONFIG_ARM64 is defined
Error: unknown or missing system register name at operand 2
-- `mrs x0,daifmsr daifset,#3'
Signed-off-by: Shaibal.Dutta <shaibal.dutta@broadcom.com>
Signed-off-by: Darwin Rambo <drambo@broadcom.com>
Reviewed-by: Darwin Rambo <drambo@broadcom.com>
---
arch/arm/include/asm/proc-armv/system.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/include/asm/proc-armv/system.h b/arch/arm/include/asm/proc-armv/system.h
index 693d1f4..c61374e 100644
--- a/arch/arm/include/asm/proc-armv/system.h
+++ b/arch/arm/include/asm/proc-armv/system.h
@@ -22,7 +22,7 @@
#define local_irq_save(flags) \
({ \
asm volatile( \
- "mrs %0, daif" \
+ "mrs %0, daif\n" \
"msr daifset, #3" \
: "=r" (flags) \
: \
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* [U-Boot] [PATCH] arm: Fix armv8 compilation error
2014-06-09 20:25 [U-Boot] [PATCH] arm: Fix armv8 compilation error Darwin Rambo
@ 2014-07-04 21:41 ` Albert ARIBAUD
2014-07-04 22:55 ` Steve Rae
2014-07-05 9:03 ` Albert ARIBAUD
1 sibling, 1 reply; 4+ messages in thread
From: Albert ARIBAUD @ 2014-07-04 21:41 UTC (permalink / raw)
To: u-boot
Hi Darwin,
On Mon, 9 Jun 2014 13:25:52 -0700, Darwin Rambo <drambo@broadcom.com>
wrote:
> From: "Shaibal.Dutta" <shaibal.dutta@broadcom.com>
>
> Fix following compilation error when CONFIG_ARM64 is defined
>
> Error: unknown or missing system register name at operand 2
> -- `mrs x0,daifmsr daifset,#3'
>
> Signed-off-by: Shaibal.Dutta <shaibal.dutta@broadcom.com>
> Signed-off-by: Darwin Rambo <drambo@broadcom.com>
> Reviewed-by: Darwin Rambo <drambo@broadcom.com>
> ---
I don't get any such error. Which board and which compiler does it
appear for?
Amicalement,
--
Albert.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] arm: Fix armv8 compilation error
2014-07-04 21:41 ` Albert ARIBAUD
@ 2014-07-04 22:55 ` Steve Rae
0 siblings, 0 replies; 4+ messages in thread
From: Steve Rae @ 2014-07-04 22:55 UTC (permalink / raw)
To: u-boot
Albert,
I don't think that there is any code currently submitted that triggers
this error.
(it is "hidden" inside inline functions...)
However, you could add one line of code 'anywhere' to test this:
test_and_set_bit(1, (volatile void *)0x12345678);
Thanks, Steve
PS.
- using:
gcc-linaro-aarch64-linux-gnu-4.8-2014.01_linux/bin/aarch64-linux-gnu-
- and: ./MAKEALL -a aarch64
On 14-07-04 02:41 PM, Albert ARIBAUD wrote:
> Hi Darwin,
>
> On Mon, 9 Jun 2014 13:25:52 -0700, Darwin Rambo <drambo@broadcom.com>
> wrote:
>
>> From: "Shaibal.Dutta" <shaibal.dutta@broadcom.com>
>>
>> Fix following compilation error when CONFIG_ARM64 is defined
>>
>> Error: unknown or missing system register name at operand 2
>> -- `mrs x0,daifmsr daifset,#3'
>>
>> Signed-off-by: Shaibal.Dutta <shaibal.dutta@broadcom.com>
>> Signed-off-by: Darwin Rambo <drambo@broadcom.com>
>> Reviewed-by: Darwin Rambo <drambo@broadcom.com>
>> ---
>
> I don't get any such error. Which board and which compiler does it
> appear for?
>
> Amicalement,
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] arm: Fix armv8 compilation error
2014-06-09 20:25 [U-Boot] [PATCH] arm: Fix armv8 compilation error Darwin Rambo
2014-07-04 21:41 ` Albert ARIBAUD
@ 2014-07-05 9:03 ` Albert ARIBAUD
1 sibling, 0 replies; 4+ messages in thread
From: Albert ARIBAUD @ 2014-07-05 9:03 UTC (permalink / raw)
To: u-boot
Hi Darwin,
On Mon, 9 Jun 2014 13:25:52 -0700, Darwin Rambo <drambo@broadcom.com>
wrote:
> From: "Shaibal.Dutta" <shaibal.dutta@broadcom.com>
>
> Fix following compilation error when CONFIG_ARM64 is defined
>
> Error: unknown or missing system register name at operand 2
> -- `mrs x0,daifmsr daifset,#3'
>
> Signed-off-by: Shaibal.Dutta <shaibal.dutta@broadcom.com>
> Signed-off-by: Darwin Rambo <drambo@broadcom.com>
> Reviewed-by: Darwin Rambo <drambo@broadcom.com>
> ---
>
> arch/arm/include/asm/proc-armv/system.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/include/asm/proc-armv/system.h b/arch/arm/include/asm/proc-armv/system.h
> index 693d1f4..c61374e 100644
> --- a/arch/arm/include/asm/proc-armv/system.h
> +++ b/arch/arm/include/asm/proc-armv/system.h
> @@ -22,7 +22,7 @@
> #define local_irq_save(flags) \
> ({ \
> asm volatile( \
> - "mrs %0, daif" \
> + "mrs %0, daif\n" \
> "msr daifset, #3" \
> : "=r" (flags) \
> : \
Applied to u-boot-arm/master, thanks!
Amicalement,
--
Albert.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-07-05 9:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-09 20:25 [U-Boot] [PATCH] arm: Fix armv8 compilation error Darwin Rambo
2014-07-04 21:41 ` Albert ARIBAUD
2014-07-04 22:55 ` Steve Rae
2014-07-05 9:03 ` Albert ARIBAUD
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox