public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Helmut Raiger <helmut.raiger@hale.at>
To: u-boot@lists.denx.de
Subject: [U-Boot] SPL broken on i.mx31 platforms, FIX?
Date: Wed, 09 Jul 2014 10:22:31 +0200	[thread overview]
Message-ID: <53BCFBC7.6040409@hale.at> (raw)
In-Reply-To: <53BBA64A.70309@hale.at>

Hi,

     finally I have the SPL running again, with this fix:

diff --git a/arch/arm/cpu/arm1136/start.S b/arch/arm/cpu/arm1136/start.S
index 1cfcca9..53bde12 100644
--- a/arch/arm/cpu/arm1136/start.S
+++ b/arch/arm/cpu/arm1136/start.S
@@ -91,4 +91,9 @@ cpu_init_crit:
         bl      lowlevel_init   /* go setup pll,mux,memory */
         mov     lr, ip          /* restore link */
         mov     pc, lr          /* back to my caller */
+
+       nop
+       nop
+       nop
+
  #endif /* CONFIG_SKIP_LOWLEVEL_INIT */
diff --git a/arch/arm/lib/vectors.S b/arch/arm/lib/vectors.S
index d68cc47..8c0e3c1 100644
--- a/arch/arm/lib/vectors.S
+++ b/arch/arm/lib/vectors.S
@@ -50,7 +50,8 @@ _start:
  #endif

  _start:
-       ldr     pc, _reset
+       /* be position independent if SPL is linked at different location */
+       b       reset
         ldr     pc, _undefined_instruction
         ldr     pc, _software_interrupt
         ldr     pc, _prefetch_abort


I have no clue why the nops are necessary after cpu_init_crit(), but it 
won't work
unless there are at least 3 nops there (pipeline?).
It would be nice to have _some_ explanation for this before posting a patch.

Helmut

--
Scanned by MailScanner.

  parent reply	other threads:[~2014-07-09  8:22 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-01 13:33 [U-Boot] SPL broken on i.mx31 platforms Helmut Raiger
2014-07-01 13:53 ` Fabio Estevam
2014-07-01 19:45   ` Albert ARIBAUD
2014-07-02  7:04     ` Helmut Raiger
2014-07-02 10:58       ` Albert ARIBAUD
2014-07-02 23:20       ` Benoît Thébaudeau
2014-07-03  8:19         ` Helmut Raiger
2014-07-03 13:35           ` Albert ARIBAUD
2014-07-03 20:58             ` Benoît Thébaudeau
2014-07-04  8:50               ` Albert ARIBAUD
2014-07-04 10:42                 ` Magnus Lilja
2014-07-04 21:42                   ` Benoît Thébaudeau
2014-07-04 21:29                 ` Benoît Thébaudeau
2014-07-03 20:58           ` Benoît Thébaudeau
2014-07-08  8:05             ` Helmut Raiger
2014-07-08 12:32               ` Helmut Raiger
2014-07-08 12:48                 ` Helmut Raiger
2014-07-09  8:22               ` Helmut Raiger [this message]
2014-07-11  7:56               ` Magnus Lilja
2014-07-15  9:31                 ` Helmut Raiger
2014-08-04 20:23                   ` Magnus Lilja
2014-08-04 20:40                     ` Jeroen Hofstee
2014-08-05 12:28                     ` Fabio Estevam
2014-08-05 12:32                       ` Magnus Lilja
2014-08-13 12:01                         ` Helmut Raiger
2014-08-15 17:45                           ` Magnus Lilja
2014-08-19 20:55                             ` Benoît Thébaudeau
2014-08-19 22:01                               ` Fabio Estevam
2014-09-03  0:53                               ` Benoît Thébaudeau
2014-09-03  1:13                                 ` Tom Rini
2014-09-04 19:12                                   ` Magnus Lilja
2014-09-04 19:50                                     ` Benoît Thébaudeau
2014-09-04 19:59                                       ` Magnus Lilja
2014-07-02  8:11   ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53BCFBC7.6040409@hale.at \
    --to=helmut.raiger@hale.at \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox