From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] ARM: omap: Fix GPMC init for OMAP3 platforms
Date: Thu, 10 Jul 2014 07:28:00 +0200 [thread overview]
Message-ID: <53BE2460.2040900@denx.de> (raw)
In-Reply-To: <20980858CB6D3A4BAE95CA194937D5E73EB0161A@DBDE04.ent.ti.com>
Hi Pekon,
On 09.07.2014 20:22, Gupta, Pekon wrote:
>> Commit a0a37183 (ARM: omap: merge GPMC initialization code for all
>> platform) broke NAND on OMAP3 based platforms. I noticed this while
>> testing the latest 2014.07-rc version on the TAO3530 board. NAND
>> detection did not work with this error message:
>>
>> NAND: nand: error: Unable to find NAND settings in GPMC Configuration - quitting
>>
>> As OMAP3 configs don't set CONFIG_NAND but CONFIG_NAND_CMD. the GPMC
>> was not initialized for NAND at all. This patch now fixes this issue.
>>
> Sorry couldn't understand this, why have users enabled CONFIG_NAND_CMD,
> if CONFIG_NAND itself is not enabled ?
CONFIG_NAND doesn't seem to be a mandatory define if NAND is used. Many
OMAP3 based boards don't enable this define but still use NAND. The
"old" mem.c also did only check for CONFIG_CMD_NAND to configure the
GPMC accordingly. Thats why I chose to change mem-common.c to accept
this kind of configuration instead of changing all those config headers
to enable CONFIG_NAND.
> Otherwise, if TAO3530 board uses the on-die NAND, then it should enable
> NAND in its board profile via boards.cfg
Sorry, I don't understand what this has to do with on-die NAND. This
patch is a clear fix to restore the original behavior with the "old" mem.c.
Thanks,
Stefan
next prev parent reply other threads:[~2014-07-10 5:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-09 15:18 [U-Boot] [PATCH 1/3] ARM: omap: Fix GPMC init for OMAP3 platforms Stefan Roese
2014-07-09 15:18 ` [U-Boot] [PATCH 2/3] ARM: omap: Remove unused arch/arm/cpu/armv7/omap3/mem.c Stefan Roese
2014-07-09 18:16 ` Gupta, Pekon
2014-07-26 1:26 ` [U-Boot] [U-Boot, " Tom Rini
2014-07-09 15:18 ` [U-Boot] [PATCH 3/3] ARM: omap: tao3530: Convert to generic board Stefan Roese
2014-07-26 1:26 ` [U-Boot] [U-Boot, " Tom Rini
2014-07-09 18:22 ` [U-Boot] [PATCH 1/3] ARM: omap: Fix GPMC init for OMAP3 platforms Gupta, Pekon
2014-07-10 5:28 ` Stefan Roese [this message]
2014-07-11 18:52 ` Tom Rini
2014-07-12 13:30 ` Gupta, Pekon
2014-07-12 14:47 ` Stefan Roese
2014-07-14 1:35 ` Gupta, Pekon
2014-07-26 1:25 ` [U-Boot] [U-Boot, " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BE2460.2040900@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox