[U-Boot] [PATCH] common: env_common: make env_get_char_spec __weak

[U-Boot] [PATCH] common: env_common: make env_get_char_spec __weak

[Jeroen Hofstee]

---
yup another clang warning:

common/env_common.c:30:14: warning: unused function '__env_get_char_spec' [-Wunused-function]
static uchar __env_get_char_spec(int index)
             ^
---
 common/env_common.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/common/env_common.c b/common/env_common.c
index cd7b4cd..3b979bc 100644
--- a/common/env_common.c
+++ b/common/env_common.c
@@ -27,12 +27,10 @@ struct hsearch_data env_htab = {
 	.change_ok = env_flags_validate,
 };
 
-static uchar __env_get_char_spec(int index)
+__weak uchar env_get_char_spec(int index)
 {
 	return *((uchar *)(gd->env_addr + index));
 }
-uchar env_get_char_spec(int)
-	__attribute__((weak, alias("__env_get_char_spec")));
 
 static uchar env_get_char_init(int index)
 {
-- 
1.8.3.2

[U-Boot] [PATCH] common: env_common: make env_get_char_spec __weak

[Jeroen Hofstee]

Hi Jeroen,

On 10-07-14 23:27, Jeroen Hofstee wrote:
> ---
> yup another clang warning:
>
> common/env_common.c:30:14: warning: unused function '__env_get_char_spec' [-Wunused-function]
> static uchar __env_get_char_spec(int index)
>               ^
> ---
>   common/env_common.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/common/env_common.c b/common/env_common.c
> index cd7b4cd..3b979bc 100644
> --- a/common/env_common.c
> +++ b/common/env_common.c
> @@ -27,12 +27,10 @@ struct hsearch_data env_htab = {
>   	.change_ok = env_flags_validate,
>   };
>   
> -static uchar __env_get_char_spec(int index)
> +__weak uchar env_get_char_spec(int index)
>   {
>   	return *((uchar *)(gd->env_addr + index));
>   }
> -uchar env_get_char_spec(int)
> -	__attribute__((weak, alias("__env_get_char_spec")));
>   
>   static uchar env_get_char_init(int index)
>   {

signed-off is missing?

Regards,
Jeroen

[U-Boot] [PATCH] common: env_common: make env_get_char_spec __weak

[Wolfgang Denk]

Dear Jeroen,

In message <1405027670-28516-1-git-send-email-jeroen@myspectrum.nl> you wrote:
>  
> -static uchar __env_get_char_spec(int index)
> +__weak uchar env_get_char_spec(int index)

__weak static ... ?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Experience is what causes a person to make new  mistakes  instead  of
old ones.

[U-Boot] [PATCH] common: env_common: make env_get_char_spec __weak

[Jeroen Hofstee]

Hello Wolfgang,

On 11-07-14 06:26, Wolfgang Denk wrote:
> Dear Jeroen,
>
> In message <1405027670-28516-1-git-send-email-jeroen@myspectrum.nl> you wrote:
>>   
>> -static uchar __env_get_char_spec(int index)
>> +__weak uchar env_get_char_spec(int index)
> __weak static ... ?

tempting huh, but it is the patch format with tricks
you in thinking that. The weak is actually added to
the function without the leading underscores, a
couple of lines below (which wasn't static and
shouldn't become so).

Regards,
Jeroen

[U-Boot] [PATCH] common: env_common: make env_get_char_spec __weak

[Wolfgang Denk]

Dear Jeroen Hofstee,

In message <53C01BD7.8030608@myspectrum.nl> you wrote:
> 
> >> -static uchar __env_get_char_spec(int index)
> >> +__weak uchar env_get_char_spec(int index)
> > __weak static ... ?
> 
> tempting huh, but it is the patch format with tricks
> you in thinking that. The weak is actually added to
> the function without the leading underscores, a
> couple of lines below (which wasn't static and
> shouldn't become so).

Argh.  You are right.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Sometimes, too long is too long.                          - Joe Crowe

[U-Boot] [PATCH v2] common: env_common: make env_get_char_spec __weak

[Jeroen Hofstee]

Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>
---
yup another clang warning:

common/env_common.c:30:14: warning: unused function '__env_get_char_spec' [-Wunused-function]
static uchar __env_get_char_spec(int index)
             ^

changes since v1:
  add missing S-O-B line
---
 common/env_common.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/common/env_common.c b/common/env_common.c
index cd7b4cd..3b979bc 100644
--- a/common/env_common.c
+++ b/common/env_common.c
@@ -27,12 +27,10 @@ struct hsearch_data env_htab = {
 	.change_ok = env_flags_validate,
 };
 
-static uchar __env_get_char_spec(int index)
+__weak uchar env_get_char_spec(int index)
 {
 	return *((uchar *)(gd->env_addr + index));
 }
-uchar env_get_char_spec(int)
-	__attribute__((weak, alias("__env_get_char_spec")));
 
 static uchar env_get_char_init(int index)
 {
-- 
1.8.3.2

[U-Boot] [U-Boot, v2] common: env_common: make env_get_char_spec __weak

[Tom Rini]

On Sat, Jul 12, 2014 at 03:22:13PM +0200, Jeroen Hofstee wrote:

> Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140721/d5d91eef/attachment.pgp>