From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeroen Hofstee <dasuboot@myspectrum.nl>
Date: Thu, 10 Jul 2014 23:51:56 +0200
Subject: [U-Boot] [PATCH] common: env_common: make env_get_char_spec
	__weak
In-Reply-To: <1405027670-28516-1-git-send-email-jeroen@myspectrum.nl>
References: <1405027670-28516-1-git-send-email-jeroen@myspectrum.nl>
Message-ID: <53BF0AFC.9040409@myspectrum.nl>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Jeroen,

On 10-07-14 23:27, Jeroen Hofstee wrote:
> ---
> yup another clang warning:
>
> common/env_common.c:30:14: warning: unused function '__env_get_char_spec' [-Wunused-function]
> static uchar __env_get_char_spec(int index)
>               ^
> ---
>   common/env_common.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/common/env_common.c b/common/env_common.c
> index cd7b4cd..3b979bc 100644
> --- a/common/env_common.c
> +++ b/common/env_common.c
> @@ -27,12 +27,10 @@ struct hsearch_data env_htab = {
>   	.change_ok = env_flags_validate,
>   };
>   
> -static uchar __env_get_char_spec(int index)
> +__weak uchar env_get_char_spec(int index)
>   {
>   	return *((uchar *)(gd->env_addr + index));
>   }
> -uchar env_get_char_spec(int)
> -	__attribute__((weak, alias("__env_get_char_spec")));
>   
>   static uchar env_get_char_init(int index)
>   {

signed-off is missing?

Regards,
Jeroen