From: Jeroen Hofstee <jeroen@myspectrum.nl>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] common: env_common: make env_get_char_spec __weak
Date: Fri, 11 Jul 2014 19:16:07 +0200 [thread overview]
Message-ID: <53C01BD7.8030608@myspectrum.nl> (raw)
In-Reply-To: <20140711042603.E38E1383170@gemini.denx.de>
Hello Wolfgang,
On 11-07-14 06:26, Wolfgang Denk wrote:
> Dear Jeroen,
>
> In message <1405027670-28516-1-git-send-email-jeroen@myspectrum.nl> you wrote:
>>
>> -static uchar __env_get_char_spec(int index)
>> +__weak uchar env_get_char_spec(int index)
> __weak static ... ?
tempting huh, but it is the patch format with tricks
you in thinking that. The weak is actually added to
the function without the leading underscores, a
couple of lines below (which wasn't static and
shouldn't become so).
Regards,
Jeroen
next prev parent reply other threads:[~2014-07-11 17:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-10 21:27 [U-Boot] [PATCH] common: env_common: make env_get_char_spec __weak Jeroen Hofstee
2014-07-10 21:51 ` Jeroen Hofstee
2014-07-11 4:26 ` Wolfgang Denk
2014-07-11 17:16 ` Jeroen Hofstee [this message]
2014-07-11 19:14 ` Wolfgang Denk
2014-07-12 13:22 ` [U-Boot] [PATCH v2] " Jeroen Hofstee
2014-07-21 20:43 ` [U-Boot] [U-Boot, " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C01BD7.8030608@myspectrum.nl \
--to=jeroen@myspectrum.nl \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox