From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeroen Hofstee Date: Fri, 11 Jul 2014 19:16:07 +0200 Subject: [U-Boot] [PATCH] common: env_common: make env_get_char_spec __weak In-Reply-To: <20140711042603.E38E1383170@gemini.denx.de> References: <1405027670-28516-1-git-send-email-jeroen@myspectrum.nl> <20140711042603.E38E1383170@gemini.denx.de> Message-ID: <53C01BD7.8030608@myspectrum.nl> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Wolfgang, On 11-07-14 06:26, Wolfgang Denk wrote: > Dear Jeroen, > > In message <1405027670-28516-1-git-send-email-jeroen@myspectrum.nl> you wrote: >> >> -static uchar __env_get_char_spec(int index) >> +__weak uchar env_get_char_spec(int index) > __weak static ... ? tempting huh, but it is the patch format with tricks you in thinking that. The weak is actually added to the function without the leading underscores, a couple of lines below (which wasn't static and shouldn't become so). Regards, Jeroen