From: Jeroen Hofstee <dasuboot@myspectrum.nl>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 2/9] arm: Set up global data before board_init_f()
Date: Fri, 11 Jul 2014 19:44:44 +0200 [thread overview]
Message-ID: <53C0228C.2050007@myspectrum.nl> (raw)
In-Reply-To: <1405052613-20987-3-git-send-email-sjg@chromium.org>
Hello Simon,
On 11-07-14 06:23, Simon Glass wrote:
> At present arm defines CONFIG_SYS_GENERIC_GLOBAL_DATA, meaning that
> the global_data pointer is set up in board_init_f(). However it is
> actually set up before this, it just isn't zeroed.
>
> If we zero the global data before calling board_init_f() then we
> don't need to define CONFIG_SYS_GENERIC_GLOBAL_DATA.
>
> Make this change (on arm32 only) to simplify the init process. I
> don't have the ability to test aarch64 yet.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
> Changes in v3:
> - Fix assembler code comment in crt0.S to say GD, not BSS
> - Ensure that aarch64 stays as it was
> - Add newline after clr_gd label
> - Remove redundant mov r0, #0
>
> Changes in v2: None
>
> arch/arm/include/asm/config.h | 2 ++
> arch/arm/lib/crt0.S | 9 +++++++++
> 2 files changed, 11 insertions(+)
Looks good to me. I picked up this one instead
of my memset version.
Thanks, Jeroen
next prev parent reply other threads:[~2014-07-11 17:44 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-11 4:23 [U-Boot] [PATCH v3 0/9] Add a pre-relocation malloc() implementation Simon Glass
2014-07-11 4:23 ` [U-Boot] [PATCH v3 1/9] Remove form-feeds from dlmalloc.c Simon Glass
2014-07-26 15:22 ` Simon Glass
2014-07-11 4:23 ` [U-Boot] [PATCH v3 2/9] arm: Set up global data before board_init_f() Simon Glass
2014-07-11 17:44 ` Jeroen Hofstee [this message]
2014-07-23 12:16 ` Simon Glass
2014-07-23 13:31 ` Tom Rini
2014-07-28 12:17 ` Simon Glass
2014-08-09 21:26 ` Simon Glass
2014-07-11 4:23 ` [U-Boot] [PATCH v3 3/9] sandbox: " Simon Glass
2014-07-26 15:22 ` Simon Glass
2014-07-11 4:23 ` [U-Boot] [PATCH v3 4/9] Add a simple malloc() implementation for pre-relocation Simon Glass
2014-07-26 15:23 ` Simon Glass
2014-07-11 4:23 ` [U-Boot] [PATCH v3 5/9] arm: Support pre-relocation malloc() Simon Glass
2014-07-23 12:19 ` Simon Glass
2014-08-09 21:25 ` Simon Glass
2014-07-11 4:23 ` [U-Boot] [PATCH v3 6/9] exynos: Enable " Simon Glass
2014-07-11 4:23 ` [U-Boot] [PATCH v3 7/9] sandbox: Support " Simon Glass
2014-07-26 15:23 ` Simon Glass
2014-07-11 4:23 ` [U-Boot] [PATCH v3 8/9] sandbox: config: Enable " Simon Glass
2014-07-26 15:24 ` Simon Glass
2014-07-11 4:23 ` [U-Boot] [PATCH v3 9/9] sandbox: Always enable malloc debug Simon Glass
2014-07-26 15:24 ` Simon Glass
2014-07-14 22:28 ` [U-Boot] [PATCH v3 0/9] Add a pre-relocation malloc() implementation Tom Rini
2014-07-15 0:16 ` Simon Glass
2014-07-23 12:24 ` Simon Glass
2014-07-23 13:41 ` Tom Rini
2014-07-28 12:16 ` Simon Glass
2014-08-04 11:21 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C0228C.2050007@myspectrum.nl \
--to=dasuboot@myspectrum.nl \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox