From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeroen Hofstee Date: Fri, 11 Jul 2014 19:44:44 +0200 Subject: [U-Boot] [PATCH v3 2/9] arm: Set up global data before board_init_f() In-Reply-To: <1405052613-20987-3-git-send-email-sjg@chromium.org> References: <1405052613-20987-1-git-send-email-sjg@chromium.org> <1405052613-20987-3-git-send-email-sjg@chromium.org> Message-ID: <53C0228C.2050007@myspectrum.nl> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Simon, On 11-07-14 06:23, Simon Glass wrote: > At present arm defines CONFIG_SYS_GENERIC_GLOBAL_DATA, meaning that > the global_data pointer is set up in board_init_f(). However it is > actually set up before this, it just isn't zeroed. > > If we zero the global data before calling board_init_f() then we > don't need to define CONFIG_SYS_GENERIC_GLOBAL_DATA. > > Make this change (on arm32 only) to simplify the init process. I > don't have the ability to test aarch64 yet. > > Signed-off-by: Simon Glass > --- > > Changes in v3: > - Fix assembler code comment in crt0.S to say GD, not BSS > - Ensure that aarch64 stays as it was > - Add newline after clr_gd label > - Remove redundant mov r0, #0 > > Changes in v2: None > > arch/arm/include/asm/config.h | 2 ++ > arch/arm/lib/crt0.S | 9 +++++++++ > 2 files changed, 11 insertions(+) Looks good to me. I picked up this one instead of my memset version. Thanks, Jeroen