public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 3/5] i.MX6: define struct pwm_regs and PWMCR_* defines
Date: Tue, 15 Jul 2014 11:27:37 +0200	[thread overview]
Message-ID: <53C4F409.3080901@denx.de> (raw)
In-Reply-To: <53C4ED44.1030604@denx.de>

Hello Stefano,

Am 15.07.2014 10:58, schrieb Stefano Babic:
> Hi Heiko,
>
> On 15/07/2014 10:52, Heiko Schocher wrote:
>
>>> I see. What do you mind to add a little effort and move the setup of the
>>> PWM from the aristaneos board to a PWM driver ? I see there is not (yet)
>>> such a driver, but why not ?
>>
>> Yes, I can do that ... Hmm, where do you think is a good place for this
>> driver?
>>
>
> IMHO you can create a drivers/pwm directory and add a pwm-imx.c driver.
> This reflects the same we have in kernel.

Yes, that was also my first thought, but we have a API for this in
include/pwm.h
but no drivers/pwm ... so I searched pwm_init and found:

pollux:u-boot hs [20140715] $ grep -lr pwm_init .
./include/.pwm.h.swp
./include/pwm.h
./arch/arm/include/asm/arch-tegra20/pwm.h
./arch/arm/cpu/armv7/s5p-common/pwm.c
./arch/arm/cpu/armv7/s5p-common/timer.c
./arch/arm/cpu/armv7/tegra20/pwm.c
./board/nvidia/common/board.c
pollux:u-boot hs [20140715] $

I think, it would better to add a "arch/arm/cpu/armv7/mx6/pwm.c"

Would this be ok?

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

  reply	other threads:[~2014-07-15  9:27 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-12  4:10 [U-Boot] [PATCH v2 0/5] arm, imx6: add aristainetos board support Heiko Schocher
2014-07-12  4:10 ` [U-Boot] [PATCH v2 1/5] spi, spi_mxc: do not hang in spi_xchg_single Heiko Schocher
2014-07-12 12:54   ` Jagan Teki
2014-07-14  7:26     ` Heiko Schocher
2014-07-14  8:01       ` Jagan Teki
2014-07-14  8:20         ` Heiko Schocher
2014-07-12  4:10 ` [U-Boot] [PATCH v2 2/5] imx6: add gpr2 usb_otg_id iomux select control define Heiko Schocher
2014-07-15  8:07   ` Stefano Babic
2014-07-12  4:10 ` [U-Boot] [PATCH v2 3/5] i.MX6: define struct pwm_regs and PWMCR_* defines Heiko Schocher
2014-07-15  8:12   ` Stefano Babic
2014-07-15  8:52     ` Heiko Schocher
2014-07-15  8:58       ` Stefano Babic
2014-07-15  9:27         ` Heiko Schocher [this message]
2014-07-15 10:40           ` Stefano Babic
2014-07-12  4:10 ` [U-Boot] [PATCH v2 4/5] i.MX6: add enable_spi_clk() Heiko Schocher
2014-07-14 17:13   ` Jagan Teki
2014-07-12  4:10 ` [U-Boot] [PATCH v2 5/5] arm, imx6: add aristainetos board Heiko Schocher
2014-07-15  8:31   ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53C4F409.3080901@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox